Repository navigation
test(db): register the plain test driver once so -count above 1 passes - #3037
Merged
Merged
Conversation
TestWithRawConn_DriverWithoutSerialize called sql.Register in the test body, which panics with "Register called twice" on a second iteration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9 Signed-off-by: vavallee <vavallee@protonmail.com>
vavallee
enabled auto-merge (squash)
October 6, 2026 18:02
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks clean. sync.Once is the right fix: sql.Register panics on a second call within the same process, which is exactly what -count=2 triggers by re-running tests in the same binary. No production code touched, no changelog fragment needed.
One minor note: the comment on registerPlainDriver (openmemory_test.go:92-93) is accurate and useful — no changes needed there.
— 🤖 Bindery triage bot (automated). Reply to correct me; a human will see it.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestWithRawConn_DriverWithoutSerialize (from #2983) called sql.Register in the test body, so go test -count=2 ./internal/db/ panics with "Register called twice for driver openmemory-plain". Wrapped it in a sync.Once. Test only, no changelog fragment.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9