Repository navigation
Conversation
GO-2026-6617 (HTTP/2 server crash from an HPACK encoder race in net/http) lands at HIGH severity in both govulncheck's and Grype's vulnerability databases as of today, both freshly updated; it is fixed in go1.26.9. The repo's pinned go1.26.8 toolchain is affected, which fails the lint job's govulncheck step and the container image's Grype scan on every PR and on main's own next run, starting now. Bumps go.mod's toolchain directive, all three Dockerfiles' golang base image (tag and digest, verified against the real registry manifest and a full docker build), and every workflow's setup-go go-version, kept in lockstep per make go-version-check (vavallee#2956's discipline). docs/ARCHITECTURE.md mentions the pinned tag and is updated to match. Verified: make go-version-check passes, govulncheck ./... is clean, full Go test suite passes, golangci-lint v2.11.4 is clean, and a full docker build -f Dockerfile . succeeds end to end. Signed-off-by: gch ahcg <gchahcg@proton.me>
10 tasks done
github-actions
Bot
added
the
bindery-notified
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
|
Thanks for catching this so quickly. #3131 had the same Go 1.26.9 bump and landed first, so I'm closing this one to avoid a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GO-2026-6617 (HTTP/2 server crash from an HPACK encoder race in
net/http), fixed in go1.26.9, landed at HIGH severity in both govulncheck's and Grype's vulnerability databases today. The repo's pinnedgo1.26.8toolchain is affected, which fails thelintjob's govulncheck step and theContainer Scanjob's Grype scan on every open PR right now, and will fail onmain's own next CI run too — I hit this on an unrelated PR (#2915) and it's not specific to that diff:main'sgo.modcarries the identical pin.Urgent and small on purpose: this blocks CI repo-wide until it merges.
What changed
Every build target that names a Go version moves together, per
make go-version-check(the discipline #2956 established):go.mod:toolchain go1.26.8→go1.26.9Dockerfile,cmd/discord-stats/Dockerfile,cmd/telemetry-server/Dockerfile:golang:1.26.8-alpine→golang:1.26.9-alpine, digest updated to the real manifest digest for that tag (fetched from the registry and cross-checked: the same method reproduces the existing1.26.8pin's known-correct digest byte for byte)setup-gogo-versionin.github/workflows/{ci,canary,fuzz,ping-drift,security}.yml(14 occurrences):"1.26.8"→"1.26.9"docs/ARCHITECTURE.md: mentions the pinned tag, updated to matchChecklist
docs/ARCHITECTURE.mdchangelog.d/go-toolchain-1.26.9-cve.mdTest plan
make go-version-check— passes (Go 1.26.9 everywhere: go.mod, 3 Dockerfiles, 18 workflows)govulncheck ./...— clean (was reporting GO-2026-6617 before the bump)go test ./cmd/... ./internal/...— full suite passes on go1.26.9golangci-lint run(v2.11.4) — 0 issuesdocker build -f Dockerfile .— succeeds end to end on the new base imagedocker pull golang:1.26.9-alpine@sha256:...🤖 Generated with Claude Code
https://claude.ai/code/session_01WA2CUNg5o4wUBaX6yWXNNk