consistency with proj4 updates#1
Open
gewitterblitz wants to merge 1 commit into
Open
Conversation
Author
|
Update: Although the code ran without any errors, the plots don't look as expected. I did not realize that @deeplycloudy had issue #29 still open in lmatools. Anyway, here are the plots in case you are curious.
Please feel free to reject this pull request. FWIW, I am currently running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fromECEF function in MapProjection class of coordinateSystems.py module needs to be updated as per the proj4 requirements as discussed in lmatools issue #28 and #29 by @deeplycloudy.
I just copied the same lines from coordinateSystem.py module in lmatools over here.
This should fix the
pyproj.exceptions.ProjError: x,y,z, and time must be same sizeerror while running theGeneral calculations at grid pointsblock withjust_rms = Falsein the LMAsimulation_full.ipynb file.