Drop BiocStyle vignette dep so webR build resolves - #79
Merged
Merged
Conversation
Switch the vignette output from BiocStyle::html_document to rmarkdown::html_document and remove BiocStyle from Suggests. rwasm cannot resolve the Bioconductor-only BiocStyle without a Remotes hint (which BiocCheck disallows), which broke the webR/gh-pages build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRiaazotsabW2TZ499LLr4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #78 removed
Remotes: bioc::BiocStyle(required by BiocCheck), the manualwebr.ymlbuild failed deterministically at rwasm dependency resolution:rwasm pulls
Suggests, which included the Bioconductor-onlyBiocStyle. Without theRemoteshint and without a Bioconductor repo, rwasm's environment can't resolve it. (The R-CMD-check CI passes because those runners have Bioconductor; the webR/rwasm environment does not.)Fix
output:switched fromBiocStyle::html_document→rmarkdown::html_document(same toc/numbering/float options).BiocStyleremoved fromSuggests.This removes the only Bioconductor dependency, so the webR build resolves — and it keeps
DESCRIPTIONclean for Bioconductor (noRemotesneeded).Verification
R CMD build: vignette renders OK with the new format.R CMD check --as-cran: 0 WARNINGs / 0 ERRORs, 3 NOTEs (URL 404 + style, non-blocking).After merge, re-run
webr.ymlto rebuild the book'sgh-pagesbuild.🤖 Generated with Claude Code