Updating Dimension door AI tests to match the intended scenarios#2
Open
starius wants to merge 2 commits into
Open
Updating Dimension door AI tests to match the intended scenarios#2starius wants to merge 2 commits into
starius wants to merge 2 commits into
Conversation
The original 1005_Spell_DimensionDoorF11 map mixed two different questions. As a one-day test, the hero must lose because five Dimension Door casts should not be possible before the deadline. As a multi-day test, the same route is a legal win because the final cast can happen after a later day starts. Keep 1005 as the constrained MUST_LOSE interpretation by limiting Cuthbert to four Dimension Door casts and documenting the one-day intent in the map description. Add 1378_Spell_DimensionDoor6 as the documented MUST_WIN clone for the legal multi-day route.
The former F8, F9, and F10 maps are legal wins once the AI can use Dimension Door exploration across multiple days. Rename them to MUST_WIN cases and update their embedded map names and descriptions. The constrained one-day negative coverage remains in the earlier failure maps and in DimensionDoorF11, while these cases now lock in the multi-day routes that the improved AI should complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the tests to vcmi/vcmi#7504
1005_Spell_DimensionDoorF11now covers the constrained one-day case and remainsMUST_LOSE: the hero is limited to four DD casts, so the route cannot be completed before the deadline.1378_Spell_DimensionDoor6as the multi-day version of the same route and marked it asMUST_WIN.F8,F9, andF10cases to normal winning DD tests:1000_Spell_DimensionDoor81002_Spell_DimensionDoor91004_Spell_DimensionDoor10All Dimension Door AI tests are green with the updated Nullkiller behavior.