Skip to content

Backport PR #3480 to release/v1.7 for Support dynamic edge size parameter for Search API#3501

Merged
Matts966 merged 2 commits intorelease/v1.7from
backport/release/v1.7/feature/search/dynamic-edge-size
Mar 23, 2026
Merged

Backport PR #3480 to release/v1.7 for Support dynamic edge size parameter for Search API#3501
Matts966 merged 2 commits intorelease/v1.7from
backport/release/v1.7/feature/search/dynamic-edge-size

Conversation

@vdaas-ci
Copy link
Copy Markdown
Collaborator

Description

SSIA

Related Issue

Versions

  • Vald Version: v1.7.17
  • Go Version: v1.25.7
  • Rust Version: v1.93.0
  • Docker Version: v29.2.1
  • Kubernetes Version: v1.35.0
  • Helm Version: v4.1.0
  • NGT Version: v2.5.1
  • Faiss Version: v1.13.2

Checklist

Special notes for your reviewer

⚠️ This PR is PoC and uses feature branch of vdaas/ngt's dynamic-edge-size branch

Summary by CodeRabbit

  • New Features

    • Added edge_size (int32) to search configuration across search APIs, exposing a new search tuning parameter.
  • Documentation

    • Updated API docs, proto schema, and OpenAPI specs to document the new edge_size field.
  • Chores

    • Updated external build source for the NGT dependency.
    • Bumped several Rust crate versions.
  • Refactor

    • Normalized API schema/reference names in OpenAPI specs for consistency.

* Support dynamic edge size parameter for Search API

* 🤖 Update license headers / Format go codes and yaml files

Signed-off-by: Vdaas CI <vald@vdaas.org>

* Fix files

* Update internal/core/algorithm/ngt/ngt.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matts966 <mattsmasa96604a@gmail.com>

* Fix arg order

* 🤖 Update license headers / Format go codes and yaml files

Signed-off-by: Vdaas CI <vald@vdaas.org>

* 🤖 Update license headers / Format go codes and yaml files

Signed-off-by: Vdaas CI <vald@vdaas.org>

* Upgrade and use default NGT

* 🤖 Update license headers / Format go codes and yaml files

Signed-off-by: Vdaas CI <vald@vdaas.org>

---------

Signed-off-by: Vdaas CI <vald@vdaas.org>
Signed-off-by: Matts966 <mattsmasa96604a@gmail.com>
Signed-off-by: Matts966 <matts966@vdaas.org>
Co-authored-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 16, 2026

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3405441
Status: ✅  Deploy successful!
Preview URL: https://ff1b298d.vald.pages.dev
Branch Preview URL: https://backport-release-v1-7-featur-nmrp.vald.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4b5392d1-4bdd-481d-897a-b6ed165bdc26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backport/release/v1.7/feature/search/dynamic-edge-size
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@vdaas-ci
Copy link
Copy Markdown
Collaborator Author

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/v1.7@849796c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.7    #3501   +/-   ##
===============================================
  Coverage                ?   25.86%           
===============================================
  Files                   ?      500           
  Lines                   ?    42392           
  Branches                ?        0           
===============================================
  Hits                    ?    10965           
  Misses                  ?    30697           
  Partials                ?      730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…/dynamic-edge-size

Signed-off-by: Matts966 <matts966@vdaas.org>
@Matts966 Matts966 merged commit 03d4afe into release/v1.7 Mar 23, 2026
291 of 299 checks passed
@Matts966 Matts966 deleted the backport/release/v1.7/feature/search/dynamic-edge-size branch March 23, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants