Attempt to make biobakery profile smaller.#16
Merged
Conversation
miraep8
changed the title
Collaborator
|
Thanks for getting this going! It looks like it deleted a bunch of comments which I'd rather retain (eg the stuff about bowtie and glpsol). It also deleted the commented tests at the bottom, which are useful for debugging when building and testing the images. |
Contributor
Author
|
Happy to add back comments etc |
Contributor
Author
|
Similarly, merging this in because it works + Nick signed off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to see if we can make this image smaller. One of the things is to try multi stage builds. Then grouping as many things as possible into each command to minimize layers. And using Nick's suggestion of wgetting the humann repo instead of using git. Let's see