fix: deploy script by using new ethers functions#10
fix: deploy script by using new ethers functions#10Agilulfo1820 wants to merge 2 commits intovechain:mainfrom
Conversation
freemanzMrojo
left a comment
There was a problem hiding this comment.
Hi @Agilulfo1820 ,
This PR is failing in the build because we are deleting the package-lock.json in the GH action.
Since updating packages is not part of this PR, could you remove that line? (on top of that, I do not think we should be deleting the lock file in the build). That should fix the issue, will approve after that.
Thanks.
Are you referring to the |
No, I mean the line in the GH action that is referred to in the link above. So this one => https://github.com/vechainfoundation/hardhat-plugin-sample-ethers/blob/main/.github/workflows/common-unit-sonar.yml#L35 |
by using ethers v6 we need to replace any instance of .address with .getAddress() and .deployed with .waitForDeployment()