Skip to content

Adding Logger module to track events#99

Open
cmchin wants to merge 21 commits into
vecnatechnologies:masterfrom
cmchin:master
Open

Adding Logger module to track events#99
cmchin wants to merge 21 commits into
vecnatechnologies:masterfrom
cmchin:master

Conversation

@cmchin

@cmchin cmchin commented Aug 4, 2015

Copy link
Copy Markdown

Questions:

  • what if theres a start signal but no end signal? How long should we wait before we assume that its the end of the session and something went wrong?
  • How much can I assume that evenInfo can has all the keys that I want it to? (For example, how do I handle events that don't have a uuid or session id?)
  • Should I not send information to new relic in logger if we're still not sure if we're going to buy it?
  • How do I minimize the amount of code I copy and paste from backbone/torso?

Comment thread modules/Logger.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation issue

@kentmw

kentmw commented Aug 4, 2015

Copy link
Copy Markdown
Contributor

To answer your questions:

  1. I haven't thought too much on this, but having a start and no end is useful information to capture.
  2. I think you should be defaulting as much as possible. A stop call though needs a UUID
  3. newrelic sending needs to be an option, not a requirement regardless if Vecna purchases it.
  4. We need to prevent copying from backbone. I think we can live with wrapping the original calls with tracking calls. We don't need the granularity of putting tracking calls inside the original methods. It should look something like:
fetch: function() {
  var eventId = Logger.track();
  Backbone.Model.prototype.fetch.apply(this, arguments);
  Logger.track(eventId);
}

This commit brings up the question of how much can we make added functionality (like sending to new relic) pluggable on top of torso.

Comment thread modules/Model.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look into $(document).ajaxStart and $(document).ajaxComplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants