Skip to content

EveryCompat (Wood Good) support - #32

Open
Partonetrain wants to merge 8 commits into
vectorwing:1.21.1from
Partonetrain:1.21.1
Open

Partonetrain wants to merge 8 commits into
vectorwing:1.21.1from
Partonetrain:1.21.1

Conversation

@Partonetrain

Copy link
Copy Markdown

This PR adds support for EveryCompat enabling automatic support for wood types for seats and palisades.

image

In support of this, this PR also changes the NeoForge version, makes palisade constructors public, and adds Atmospheric (and its dep) to build.gradle (as runtimeOnly) to add some wood types for testing.

ModParticleTypes.PARTICLE_TYPES.register(modEventBus);
ModCreativeTabs.CREATIVE_MODE_TABS.register(modEventBus);

if(LoadingModList.get().getModFileById("everycomp") != null){ //there is probably a better way to check?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mod initialization is late enough you can just use ModList.get().isLoaded.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. I tend to forget all the different ways between Fabric, NeoForge, and Multiloader setups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants