Include sigma av as another parameter for starwave to use. - #25
Include sigma av as another parameter for starwave to use.#25joycelin1123 wants to merge 3 commits into
Conversation
Add in sig_av in get_cmd and sample_cmd as a new parameter for starwave to use.
Add in sig_av as a parameter in the make_params function
|
It would seem that this PR also includes the export of other quantities (sdict) from the get_cmd method. Please clean that up and submit a separate PR for that, so it's documented. |
|
Looking a little closer into this PR. While it is a good idea to have a "sigma_av" to allow for (a gaussian form of) differential reddening, I would suggest withdrawing it and rearranging things to use a truncated gaussian, in order to avoid the extinction from assuming negative values: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.truncnorm.html |
Add in sig_av as another parameter. In starwave.py, get_cmd and sample_cmd have been updated to include this change. In parameters.py, make_params has been updated with an extra line to include this.