Add CLI parity commands and server diagnostics#277
Merged
Conversation
jonmmease
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fills several API parity gaps across the CLI and server surfaces. One motivation is to make it simpler to document the different APIs, but these are also generally useful.
The CLI now exposes scenegraph conversion directly through
vl2sgandvg2sg. JSON is the default output format, and--format msgpackprovides the binary MessagePack path already available through the Rust, Python, and server APIs. The scenegraph commands accept the same conversion controls as the neighboring Vega/Vega-Lite commands, including locale options and render overrides.The CLI also gains
bundle-js, which mirrors the existing bundle APIs by either producing the default Vega Embed bundle or bundling a caller-provided snippet via--snippet <path|->.For render options, Vega and Vega-Lite CLI conversion commands backed by
VlOpts/VgOptsnow accept--width,--height, and--background, so callers can apply per-conversion overrides without editing the spec.On the server side, the admin surface now includes
GET /admin/diagnostics/workersfor per-worker V8 heap statistics./infozalso includes the local timezone used by Vega, cached at startup so the health/info endpoint does not query workers per request.