Remove deprecated Python PDF scale parameter#278
Merged
Conversation
jonmmease
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the deprecated Python-only
scalekeyword from PDF conversion APIs. PDF output is vector output produced through the SVG-to-PDF path, so the old parameter was a compatibility shim that warned for non-1.0values and did not affect the result.The sync and asyncio Python bindings,
vl_convert.pyisignatures, and tests now treatscaleas an unexpected keyword forvega_to_pdf,vegalite_to_pdf, andsvg_to_pdf. The CLI README examples no longer show PDF commands with--scale.The converter test HTTP fixture now uses
tiny_httpinstead of a hand-rolled TCP accept loop, which keeps the URL allowlist tests closer to normal HTTP behavior while staying test-only.