Skip to content

fix(docs): straighten component nav indicator #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trsoliu merged 1 commit into from
Jun 2, 2026
Merged

fix(docs): straighten component nav indicator #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions apps/docs/app/site.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2466,10 +2466,6 @@
background: var(--vk-surface-muted);
}

.vekui-components-nav-item[data-state="active"] {
box-shadow: inset 2px 0 0 var(--vk-accent);
}

.vekui-components-content {
max-width: 860px;
}
Expand Down Expand Up @@ -2747,6 +2743,19 @@
border-radius: 0;
min-height: 31px;
padding: 5px 0;
position: relative;
}

.vekui-components-nav-item::before {
background: var(--vk-ink);
bottom: 5px;
content: "";
left: 0;
opacity: 0;
pointer-events: none;
position: absolute;
top: 5px;
width: 2px;
}

.vekui-components-nav-item:hover,
Expand All @@ -2761,11 +2770,14 @@
}

.vekui-components-nav-item[data-state="active"] {
box-shadow: inset 2px 0 0 var(--vk-ink);
font-weight: 600;
padding-left: 10px;
}

.vekui-components-nav-item[data-state="active"]::before {
opacity: 1;
}

.vekui-components-toolbar {
margin-bottom: 22px;
padding-bottom: 18px;
Expand Down Expand Up @@ -3292,7 +3304,6 @@ header .nextra-hamburger {
}

.vekui-components-nav-item[data-state="active"] {
border-left: 2px solid var(--vk-ink);
box-shadow: none;
padding-left: 8px;
}
Expand Down
41 changes: 41 additions & 0 deletions apps/docs/scripts/check-code-blocks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ function assertRuleIncludes(source, selector, expected, message) {
}
}

function assertRuleExcludes(source, selector, forbidden, message) {
const escapedSelector = selector.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")
const blocks = [...source.matchAll(new RegExp(`${escapedSelector}\\s*\\{([\\s\\S]*?)\\n\\}`, "g"))].map(
(match) => match[1]
)

if (blocks.some((block) => block.includes(forbidden))) {
throw new Error(message)
}
}

assertIncludes(
componentPage,
"tokenizeTsxLine",
Expand Down Expand Up @@ -181,5 +192,35 @@ assertRuleIncludes(
"opacity: 1;",
"Active status tabs should reveal the independent indicator."
)
assertRuleIncludes(
siteCss,
".vekui-components-nav-item",
"position: relative;",
"Components nav items should anchor an independent active indicator."
)
assertRuleIncludes(
siteCss,
".vekui-components-nav-item::before",
"background: var(--vk-ink);",
"Components nav active indicators should render as a straight pseudo-element instead of a curved item border."
)
assertRuleIncludes(
siteCss,
'.vekui-components-nav-item[data-state="active"]::before',
"opacity: 1;",
"Active components nav items should reveal the independent indicator."
)
assertRuleExcludes(
siteCss,
'.vekui-components-nav-item[data-state="active"]',
"border-left:",
"Active components nav items should not draw the indicator with a curved border-left."
)
assertRuleExcludes(
siteCss,
'.vekui-components-nav-item[data-state="active"]',
"box-shadow: inset",
"Active components nav items should not draw the indicator with a curved inset shadow."
)

console.log("Code block rendering checks passed.")