Skip to content

test(e2e): pin a11y dashboard pages to the fixture date range - #148

Merged
velixio merged 1 commit into
mainfrom
fix/e2e-a11y-fixed-range
Nov 2, 2026
Merged

velixio merged 1 commit into
mainfrom
fix/e2e-a11y-fixed-range

Conversation

@velixio

@velixio velixio commented Nov 2, 2026

Copy link
Copy Markdown
Owner

The a11y audit opened the dashboard with the default rolling period. The e2e fixture data is fixed at 2026-09-28..30, so once those days left the window the Where card had no countries, the world map never rendered, and three a11y tests failed (seen on #146). The dashboard and sessions pages now use the same fixed custom range as the other dashboard specs.

Verified locally: without the change the skip-link test fails with the same world-map locator error as CI, and with it all 4 a11y tests pass.

The fixture data is fixed at 2026-09-28..30. With the default rolling period
the dashboard lost it once those days left the window, so the world map
never rendered and the a11y audit failed.
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1f82488 and 013fc0b.

Files selected for processing: 1
  • web/e2e/a11y-audit.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The accessibility audit and dashboard screenshot tests now use a fixed date range from 28 to 30 September 2026, matching the period of the E2E fixture data.

Changes: Accessibility test date range

Layer / File(s) Summary
Set date range on test routes
web/e2e/a11y-audit.spec.ts
The audit, skip-link test, and breakpoint screenshot test now include the fixed date range in their dashboard and sessions routes.

Possibly related PRs

  • velixio/supermetry#145: Keeps fixture sites outside the retention window for the same 28–30 September 2026 fixture period.
Merge Risk: Minimal · up to 013fc

This test-only change aligns accessibility routes with the available fixture dates and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: pinning a11y dashboard pages to the fixture date range.
Description check Passed The description explains the failing behaviour, the fixed date range, the affected pages, and the reported verification results. It is directly related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

@velixio
velixio merged commit f795e9f into main Nov 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant