fix(plugin-types): build to dist so runtime value imports work - #91
Merged
Conversation
main pointed at raw TS source; type-only imports were fine but the new hub-sections route value-imports SLOT_CATALOG, and node crashed requiring a .ts file in the production image. Build the package like the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.2.0 api image crash-loops:
hub-sections.jsvalue-importsSLOT_CATALOGfrom@vencore/plugin-types, whosemainpointed at raw TS source. Type-only imports never hit this; the new route is the first runtime value import, so node tried to require a .ts file and died ("Unexpected token 'export'").@vencore/plugin-typesnow builds todistwith a propermain/types, like every other packagenode -e "require('./apps/api/dist/routes/hub-sections.js')"loads clean; full build 11/11; 396/396 api tests