Skip to content

Fix display width and height of canvas for non-responsive charts #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mharmer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix display width and height of canvas for non-responsive charts #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions webcomponent/chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ customElements.define(

this.appendChild(canvasContainer)
const canvas = this.getElementsByTagName("canvas")[0]

// Setup the display size of the canvas to match the requested width/height,
// this will normally only work if the option responsive field is set to False.
canvas.width = this.getAttribute("chartWidth")
canvas.height = this.getAttribute("chartHeight")

const ctx = canvas.getContext("2d")
this._chart = new Chart(ctx, this._chartConfig)
}
Expand Down