Skip to content

perf: cache loadConfig() and ensureConfigDir() results to eliminate repeated disk reads #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mediumWellness wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: cache loadConfig() and ensureConfigDir() results to eliminate repeated disk reads #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/lib/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,38 @@ const CONFIG_FILE = path.join(CONFIG_DIR, 'config.json');
const HISTORY_FILE = path.join(CONFIG_DIR, 'history.json');
const USAGE_FILE = path.join(CONFIG_DIR, 'usage.json');

let _configDirEnsured = false;

export function ensureConfigDir(): void {
if (_configDirEnsured) return;
if (!fs.existsSync(CONFIG_DIR)) {
fs.mkdirSync(CONFIG_DIR, { recursive: true, mode: 0o700 });
}
_configDirEnsured = true;
}

let _configCache: VeniceConfig | null = null;

export function loadConfig(): VeniceConfig {
if (_configCache !== null) return _configCache;
ensureConfigDir();
try {
if (fs.existsSync(CONFIG_FILE)) {
const content = fs.readFileSync(CONFIG_FILE, 'utf-8');
return JSON.parse(content);
_configCache = JSON.parse(content);
return _configCache!;
}
} catch {
// Return empty config on error
}
return {};
_configCache = {};
return _configCache;
Comment on lines 38 to +42
}

export function saveConfig(config: VeniceConfig): void {
ensureConfigDir();
fs.writeFileSync(CONFIG_FILE, JSON.stringify(config, null, 2), { mode: 0o600 });
_configCache = config; // keep cache in sync
}

export function getConfigValue(key: keyof VeniceConfig): unknown {
Expand Down