fix: activate effort control in background turns - #6
Merged
Conversation
Owner
Author
|
Exact-head review for 7576726: compared current ChatGPT DOM evidence and upstream 4.0.4. The visible Pro effort trigger is the sole neutral composer menu pill, while the launcher background renderer reports a 1x1 viewport. This patch avoids Playwright geometry only for that single unambiguous menu button and retains fail-closed menu/slider plus selected-effort postconditions. Local: 77 provider contract tests, 49 launcher tests, typecheck all pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-submit CGW Pro failure where Electron reports a 1x1 background viewport and Playwright rejects the effort pill as outside the viewport.\n\n- restores the current neutral composer effort pill fallback\n- requires exactly one visible model/effort control\n- uses bounded DOM button activation for background surfaces\n- preserves menu/slider and selected-effort postcondition checks\n- bumps the release to 3.0.6 (3.0.5 is reserved by a separate local candidate)\n\nLocal verification: 77 focused provider tests, 49 launcher browser-host tests, and TypeScript typecheck.