Skip to content

ci(aot-probe): fail on ILC 'will always throw' lines, not only on 'warning IL' #336

Open

Description

@Harol-Reina

Sdk 2.7.0 shipped OpenTelemetry 1.19.1 with OpenTelemetry.Exporter.Prometheus.AspNetCore 1.15.2-beta.1. ILC printed PrometheusSerializer.WriteDouble ... will always throw because: Failed to load type 'OpenTelemetry.Internal.MathHelper', and the AOT binary served an empty /metrics. The aot-probe job only greps warning IL, so it stayed green. Only an adversarial agent reading the full publish log caught it (cascade sdk-2-7-0-pin-cascade, #332, which pinned the exporter). Proposal: make aot-probe fail on any will always throw line, with an allowlist for known-benign ones. The Sdk is evaluating the same rule for its canary (Sdk backlog H167).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions