chore(release): move the package validation baseline to 2.6.0 - #312
Merged
Merged
Conversation
Step two of the release ritual, the same shape #265 took after 2.5.3: with 2.6.0 published and indexed on nuget.org (29/29 verified against the flat container, not against the workflow's own canary poll), ApiCompat compares against it instead of against 2.5.3. That makes all fourteen `CompatibilitySuppressions` entries obsolete, so the three files go with the bump: src/Verbara.Sdk/CompatibilitySuppressions.xml 2 entries src/Verbara.Sdk.Ari/CompatibilitySuppressions.xml 6 src/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xml 6 They existed to let the AudioSocket frame-type corrections and the `CreateExternalMediaAsync` signature change pack against a 2.5.3 baseline that still held the old surface. Against 2.6.0 there is no diff to suppress. Left in place they would mask the *next* break of the same shape, which is the reason they move with the baseline rather than later. Verified, with a negative control rather than by trusting a green pack — `dotnet pack` validation is incremental and a gate that never ran reports success: - baseline 2.6.0, no suppressions: `dotnet pack Verbara.Sdk.slnx -c Release` exits 0, produces 29 packages, zero errors and zero warnings. - baseline 2.5.3, no suppressions: exits 1 with the six ApiCompat errors the Ari file used to carry — `CP0011: Value of field 'Uuid' in enum 'AudioFrameType' changed from '0' to '1'` and five more. The gate is live, and the suppressions really are what was holding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step two of the release ritual — the same shape #265 took after 2.5.3. With 2.6.0 published, ApiCompat
compares against it instead of against 2.5.3, which makes all fourteen
CompatibilitySuppressionsentries obsolete.
What goes
src/Verbara.Sdk/CompatibilitySuppressions.xmlsrc/Verbara.Sdk.Ari/CompatibilitySuppressions.xmlsrc/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xmlThey existed so the AudioSocket frame-type corrections (#302) and the
CreateExternalMediaAsyncsignature change (#305) could pack against a 2.5.3 baseline that still held the old surface. Against
2.6.0 there is no diff to suppress.
They move with the baseline rather than later on purpose. Left in place, they would silently mask
the next break of the same shape — an enum value changed, a member removed — and nothing would
report it.
Verified with a negative control, not with a green pack
dotnet packvalidation is incremental, so a gate that never ran reports success. Both directionswere run:
The six errors in the failing direction are exactly the six the Ari file used to carry. The gate is
live, and the suppressions really were what was holding it.
Release state
2.6.0 is tagged (
v2.6.0→e1a731fe),publish.ymlsucceeded, and 29 of 29 packages are indexedon nuget.org — checked package by package against the flat container rather than trusting the
workflow's own canary poll, which covers one package.
🤖 Generated with Claude Code