Skip to content

chore(deps-dev): bump vitest and @vitest/coverage-v8 to 4.1.11 together - #109

Merged
Harol-Reina merged 1 commit into
mainfrom
chore/vitest-4.1.11-pair
Sep 20, 2026
Merged

Harol-Reina merged 1 commit into
mainfrom
chore/vitest-4.1.11-pair

Conversation

@Harol-Reina

Copy link
Copy Markdown
Contributor

Why this exists instead of #94 / #95

Dependabot split one upgrade into two PRs, and neither can ever go green alone:

Either way the pair straddles two versions and npm refuses to install:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error While resolving: @vitest/coverage-v8@4.1.10

That is why both have been red on test, coverage and quality since 2026-08-24 — the failure is at install time, before a single test runs. package.json additionally overrides html-validate's nested vitest with "vitest": "$vitest", so the direct dependency's version is the one that has to move.

This PR moves both in one commit.

Verified locally

npm ci resolves clean, then the full CI lane:

Step
npm run check ✅
npm run lint ✅
npm run test:i18n ✅
npm run validate:digests ✅
npm test ✅ 6 files, 92 passed
npm run build ✅
npm run validate:html ✅
npm run test:coverage ✅ 97.59% statements · 93.51% branches · 100% functions

Lockfile confirms both node_modules/vitest and node_modules/@vitest/coverage-v8 at 4.1.11.

Follow-up worth doing

Add a dependabot group for vitest / @vitest/* so this pair never gets split again — otherwise the next patch release reproduces exactly this stalemate.

Closes #94
Closes #95

Dependabot split this one upgrade across two PRs (#94 bumps `vitest`, #95
bumps `@vitest/coverage-v8`), and neither can pass on its own: each leaves the
pair straddling 4.1.10 and 4.1.11, and npm refuses to install it.

  npm error code ERESOLVE
  npm error While resolving: @vitest/coverage-v8@4.1.10

Both have therefore been red on `test`, `coverage` and `quality` since
2026-08-24. `package.json` also overrides html-validate's nested vitest with
`$vitest`, so the direct dependency's version has to be the one that moves.

Moving both in one commit. Verified locally: npm ci clean, then check, lint,
test:i18n, validate:digests, test (92 passed), build, validate:html and
test:coverage (97.59% statements) all green.

Closes #94
Closes #95
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
verbara-website 2ecf63f Commit Preview URL

Branch Preview URL
Sep 20 2026, 01:23 PM

@Harol-Reina
Harol-Reina added this pull request to the merge queue Sep 20, 2026
Merged via the queue into main with commit eb9fb92 Sep 20, 2026
11 checks passed
@Harol-Reina
Harol-Reina deleted the chore/vitest-4.1.11-pair branch September 20, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant