fix(agents): route worker models by available profiles - #18
Closed
guustavomv wants to merge 1 commit into
Closed
guustavomv wants to merge 1 commit into
guustavomv wants to merge 1 commit into
Conversation
|
Obrigado pela contribuição, @guustavomv. O #20 já foi mesclado e incorpora os pontos centrais deste PR: IDs canônicos com prefixo de plano, perfis semânticos fast/review/coding/testing/balanced, suporte a profile: em skills inline e forked, fallback seguro dos aliases Claude e diagnósticos de roteamento. A solução mesclada também mantém os papéis anunciados pelo router como autoritativos e acrescenta limites de execução, timeout com resultado parcial e garantia de pareamento tool_use/tool_result. Por isso, este PR ficou substituído pelo #20 e será encerrado. Valeu por levantar o problema e pela base das melhorias de catálogo e perfis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast,review,coding,testing, andbalanced) against the authenticated Verboo/modelscatalogmax/qwen3.6-27bhaiku,sonnet, andopus) inherit the parent model on non-Claude-native providersmodel: profile:<name>in forked and inline skills while keeping existing external-provider routing compatibleMotivation and runtime evidence
The planner itself was running on
gpt-5.6-sol, but delegated calls could fail or take a long time because the harness forwarded model identifiers that the active provider did not expose.Observed in real Verboo transcripts before this fix:
worker-testssent the unqualified IDqwen3.6-27b; the authenticated catalog exposedmax/qwen3.6-27b, so the call failed before editing any fileprofile:balancedliterally instead of resolving itsonnetand thenopus; both finished with 0 tool uses, 0 tokens, and 0 seconds because those aliases were unavailable on the current providerObserved with the catalog-aware Explore route:
gpt-5.6-solhaikuexecuted with the available fast modelmax/deepseek-v4-flashThis change makes the same behavior general across account plans: profiles choose the best preferred model that is actually returned by
/models, then preserve its canonical ID. If no candidate is available, the agent inherits the parent model unlessfirst-availableis explicitly configured.Impact
Testing
bun run buildbun run smokebun test src/utils/model/agent.test.ts src/services/api/agentRouting.test.ts src/query/model.test.ts src/tools/SkillTool/SkillTool.test.ts src/skills/loadSkillsDir.test.ts(64 pass, 0 fail)Notes
gpt-5.6-sol, catalog-qualified worker IDs, and non-Claude-native alias fallback~/.verbooskill/settings changes are intentionally not part of this repository PR