fix(skills): preserve scoped models across async continuations - #26
Closed
guustavomv wants to merge 5 commits into
Closed
guustavomv wants to merge 5 commits into
guustavomv wants to merge 5 commits into
Conversation
guustavomv
marked this pull request as draft
August 8, 2026 20:30
added 4 commits
August 8, 2026 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Custom planning skills can lose their declared model after a background-agent completion notification: an initial
/planrequest begins ongpt-5.6-sol, while a queued continuation falls back to the session model. A separate production failure affected OpenAI-compatible tool calling: the configuredmax/deepseek-v4-proexecution coordinator repeatedly emittedReainstead ofRead, burning calls before falling back to Bash.Changes
effortin the inlinecommand_permissionsattachment.task-notificationcontinuations.Rea+dbefore tool finalization.Reproduction evidence
From an interactive
/executesession with--debug-file:max/minimax-m3, but the effective skill API calls wereprovider: openai,model: max/deepseek-v4-pro.Unknown tool Reaentries, and the transcript contained repeatedError: No such tool available: Rearesults.Readand usedBash, which succeeded. This isolated the failure to tool-name handling rather than repository access or permissions.The companion orchestration-pack mitigation is published separately in
guustavomv/verboo-orchestration-packcommit5bc7e20:/executeno longer exposesReadand instructs the coordinator to read contracts using read-only Bash commands. A later/executerun made onlyBashcalls and showed no newUnknown tool Reaerrors.Planning bundles intentionally remain outside the harness configuration directory at
/.plans/through orchestration-pack commitf726c17; no special permission exception is included in this PR.Validation
bun test src/Tool.test.ts src/services/tools/StreamingToolExecutor.toolPairing.test.ts src/services/api/openaiShim.test.ts src/utils/processUserInput/activeSkillScope.test.ts: 122 passed, 0 failed.bun run build: CLI and SDK bundles built and validated.The repository-wide
tsc --noEmitstill reports the existing upstream baseline of unrelated missing modules/type errors; the touched production paths introduce no new targeted errors.