Skip to content

Fix stale DataView after WASM memory growth #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stale DataView after WASM memory growth #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/@wterm/core/src/wasm-bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export class WasmBridge implements TerminalCore {
private maxCols = 256;
private encoder = new TextEncoder();
private decoder = new TextDecoder();
private _dv!: DataView;

constructor(instance: WebAssembly.Instance) {
this.exports = instance.exports as unknown as WasmExports;
Expand Down Expand Up @@ -93,7 +92,6 @@ export class WasmBridge implements TerminalCore {
this.writeBufferPtr = this.exports.getWriteBuffer();
this.cellSize = this.exports.getCellSize();
this.maxCols = this.exports.getMaxCols();
this._dv = new DataView(this.memory.buffer);
}

writeString(str: string): void {
Expand All @@ -114,7 +112,7 @@ export class WasmBridge implements TerminalCore {

getCell(row: number, col: number): CellData {
const offset = this.gridPtr + (row * this.maxCols + col) * this.cellSize;
const dv = this._dv;
const dv = new DataView(this.memory.buffer);
return {
char: dv.getUint32(offset, true),
fg: dv.getUint16(offset + 4, true),
Expand Down Expand Up @@ -181,7 +179,7 @@ export class WasmBridge implements TerminalCore {
getScrollbackCell(offset: number, col: number): CellData {
const ptr = this.exports.getScrollbackLine(offset);
const off = ptr + col * this.cellSize;
const dv = this._dv;
const dv = new DataView(this.memory.buffer);
return {
char: dv.getUint32(off, true),
fg: dv.getUint16(off + 4, true),
Expand Down