Skip to content

feat(eve): replace approval denial with cancel - #1339

Closed
benpankow wants to merge 2 commits into
ben/hitl-authorized-responders-designfrom
ben/hitl-approval-protocol
Closed

feat(eve): replace approval denial with cancel#1339
benpankow wants to merge 2 commits into
ben/hitl-authorized-responders-designfrom
ben/hitl-approval-protocol

Conversation

@benpankow

@benpankow benpankow commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Renames HITL approval response option IDs from approve/deny to approve/cancel - this more clearly aligns option text with authorization requirement (approve requires authz, cancel does not, wheras "deny" conveys that it might require authz)

Validation

  • pnpm --filter eve test:unit
  • pnpm --filter eve typecheck
  • pnpm docs:check

Stack

Depends on #1337.

Signed-off-by: benpankow <ben.pankow@vercel.com>
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eve-docs Ready Ready Preview, Comment Jul 29, 2026 6:48pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
eve-docs-4759 Skipped Skipped Jul 29, 2026 6:48pm

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Bundle + Package Summary: apps/fixtures/weather-agent

Key takeaways

  • Package delta: install footprint 89.99 MB -> 91.05 MB (+1.05 MB ⚠️).
  • Dependency delta: 1 runtime dep changed.

Delta vs ben/hitl-authorized-responders-design (fc0e46a)

Area Metric Baseline Current Delta
Package Packed tarball 7.42 MB 7.61 MB +183.4 kB ⚠️
Package Unpacked publish size 27.93 MB 28.74 MB +810.4 kB ⚠️
Package Installed footprint 89.99 MB 91.05 MB +1.05 MB ⚠️
Package Published files 2788 2855 +67
Package Installed files 6571 6642 +71
Runtime Unique function payloads 2 2 0
Runtime Total function bytes 16.49 MB 16.72 MB +232.1 kB ⚠️
Runtime Public routes 11 11 0
Dependency manifest changes vs ben/hitl-authorized-responders-design (fc0e46a)

Runtime dependencies

  • Changed: undici@7.28.0 -> undici@8.9.0
Changed function payloads vs ben/hitl-authorized-responders-design (fc0e46a) (2)
Function Status Baseline Current Delta Route changes
functions/__server.func changed 8.25 MB 8.36 MB +116.0 kB ⚠️ none
functions/.well-known/workflow/v1/flow.func changed 8.25 MB 8.36 MB +116.0 kB ⚠️ none

eve init install

Metric Baseline Current Delta
Installed footprint 128.40 MB 129.45 MB +1.05 MB ⚠️
Installed packages 130 130 0
dependencies 4 4 0
devDependencies 2 2 0
Dependency package bytes 42.31 MB 43.08 MB +762.5 kB ⚠️
devDependency package bytes 5.04 MB 5.04 MB 0 B ➖
eve init dependency changes vs ben/hitl-authorized-responders-design (fc0e46a)

dependencies

  • Changed: ai@^7.0.34 -> ai@^7.0.38, eve@file:eve-0.27.8.tgz -> eve@file:eve-0.27.12.tgz
Build Metadata
  • Preset: vercel
  • Nitro: nitro@3.0.260610-beta
  • Output directory: apps/fixtures/weather-agent/.vercel/output
  • Build metadata timestamp: 2026-07-29T18:48:59.919Z
  • Route aliases: 11 public, 1 internal (12 total aliases)
  • Vercel routes in config: 14
  • Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small
Package Drill-Down

Package Details

  • Package: eve@0.27.12
  • Package directory: packages/eve
  • Tarball: 7.61 MB (eve-0.27.12.tgz)
  • Unpacked payload: 28.74 MB across 2855 published files
  • Installed footprint: 91.05 MB across 6642 installed files
  • Installed root package: 27.39 MB
  • Installed dependencies: 63.66 MB
  • Runtime dependencies: 2
  • Peer dependencies: 5 (4 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.

Heavy installed dependencies

  • eve: 27.39 MB (30.1%)
  • @rolldown/binding-linux-x64-gnu: 19.28 MB (21.2%)
  • @rolldown/binding-wasm32-wasi: 10.66 MB (11.7%)
  • ai: 6.53 MB (7.2%)
  • @napi-rs/wasm-runtime: 6.39 MB (7.0%)
Publish payload breakdown
Published file size
🔴 dist/src/compiled/shadcn-registry/index.js       [########################] 13.15 MB 45.8%
🟠 dist/src/compiled/experimental-ai-sdk-code-mo... [###.....................] 1.51 MB 5.2%
🟡 dist/src/compiled/@vercel/sandbox/index.js       [#.......................] 632.5 kB 2.2%
🟡 dist/src/compiled/_chunks/workflow/undici-DWL... [#.......................] 502.4 kB 1.7%
🟡 dist/src/compiled/@chat-adapter/slack/index.js   [#.......................] 440.5 kB 1.5%
🔴 Other published files                            [#######################.] 12.51 MB 43.5%
Installed footprint breakdown
Installed package size
🔴 eve                             [########################] 27.39 MB 30.1%
🔴 @rolldown/binding-linux-x64-gnu [#################.......] 19.28 MB 21.2%
🔴 @rolldown/binding-wasm32-wasi   [#########...............] 10.66 MB 11.7%
🔴 ai                              [######..................] 6.53 MB 7.2%
🔴 @napi-rs/wasm-runtime           [######..................] 6.39 MB 7.0%
🔴 zod                             [####....................] 5.07 MB 5.6%
🔴 Other installed packages        [##############..........] 15.73 MB 17.3%
Runtime dependencies (2)
Package Range Notes
nitro 3.0.260610-beta
undici 8.9.0
Peer dependencies (5)
Package Range Notes
@opentelemetry/api ^1.0.0 optional peer
ai catalog:
braintrust ^3.0.0 optional peer
just-bash ^3.0.0 optional peer
microsandbox ^0.5.0 optional peer
eve init install drill-down

eve init install details

  • Command: eve init my-agent
  • Package manager: npm
  • Installed footprint: 129.45 MB across 8510 installed files
  • Installed packages: 130 total (124 transitive-only)
  • dependencies: 4 direct packages totaling 43.08 MB
  • devDependencies: 2 direct packages totaling 5.04 MB
  • Other transitive package files: 81.33 MB

Installed footprint is measured from an isolated temporary eve init my-agent using the current packed eve tarball.

Heavy installed dependencies

  • @typescript/typescript-linux-x64: 27.95 MB (21.6%)
  • eve: 27.39 MB (21.2%)
  • @rolldown/binding-linux-x64-gnu: 19.28 MB (14.9%)
  • @rolldown/binding-wasm32-wasi: 10.66 MB (8.2%)
  • zod: 9.02 MB (7.0%)
Installed footprint breakdown
Installed package size
🔴 @typescript/typescript-linux-x64 [########################] 27.95 MB 21.6%
🔴 eve                              [########################] 27.39 MB 21.2%
🔴 @rolldown/binding-linux-x64-gnu  [#################.......] 19.28 MB 14.9%
🔴 @rolldown/binding-wasm32-wasi    [#########...............] 10.66 MB 8.2%
🔴 zod                              [########................] 9.02 MB 7.0%
🔴 ai                               [######..................] 6.53 MB 5.0%
🔴 @napi-rs/wasm-runtime            [#####...................] 6.39 MB 4.9%
🔴 Other installed packages         [###################.....] 22.23 MB 17.2%
dependencies (4)
Package Range Installed size Share
@vercel/connect 0.4.2 135.8 kB 0.1%
ai ^7.0.38 6.53 MB 5.0%
eve file:eve-0.27.12.tgz 27.39 MB 21.2%
zod 4.4.3 9.02 MB 7.0%
devDependencies (2)
Package Range Installed size Share
@types/node 24.x 2.54 MB 2.0%
typescript 7.0.2 2.50 MB 1.9%
Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 8.36 MB 50.0%
🔴 functions/__server.func                         [########################] 8.36 MB 50.0%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 8.36 MB
Metric Value
Public routes /.well-known/workflow/v1/flow
Runtime nodejs24.x
Handler index.mjs
Payload 8.36 MB
Function files 8.36 MB across 44 files
Traced dependencies 0 B
Signal 🟠 Bundled file index.mjs is 2.27 MB (27.1%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                       [#######################.] 2.27 MB 27.1%
🟠 _chunks/runtime-artifacts.mjs   [################........] 1.59 MB 19.0%
🟡 _libs/undici.mjs                [##########..............] 980.5 kB 11.7%
🟡 _chunks/sandbox.mjs             [########................] 768.8 kB 9.2%
🟡 _libs/@ai-sdk/gateway+[...].mjs [####....................] 432.8 kB 5.2%
🟠 Other bundled files             [########################] 2.33 MB 27.8%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve776561746865722d6167656e74_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ],
  "environment": {
    "WORKFLOW_PRECONDITION_GUARD": "1"
  }
}

🟠 functions/__server.func • 10 public routes, 1 internal alias • 8.36 MB
Metric Value
Public routes /
/eve/v1/callback/[token]
/eve/v1/connections/[name]/callback/[token]
/eve/v1/health
/eve/v1/info
/eve/v1/session
/eve/v1/session/[sessionId]
/eve/v1/session/[sessionId]/cancel
/eve/v1/session/[sessionId]/stream
/eve/v1/session/reset
Internal aliases /__server
Runtime nodejs24.x
Handler index.mjs
Payload 8.36 MB
Function files 8.36 MB across 44 files
Traced dependencies 0 B
Signal 🟠 Bundled file index.mjs is 2.27 MB (27.1%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                       [#######################.] 2.27 MB 27.1%
🟠 _chunks/runtime-artifacts.mjs   [################........] 1.59 MB 19.0%
🟡 _libs/undici.mjs                [##########..............] 980.5 kB 11.7%
🟡 _chunks/sandbox.mjs             [########................] 768.8 kB 9.2%
🟡 _libs/@ai-sdk/gateway+[...].mjs [####....................] 432.8 kB 5.2%
🟠 Other bundled files             [########################] 2.32 MB 27.8%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

Build Timing: e2e/fixtures/agent-tools-sandbox

This is an informational timing measurement inside eve build, from preflight through publication. Output-size measurement and profile writing are excluded.

Build mode: deployable Vercel build with sandbox template prewarm included.

  • Build pipeline: 2.05 s -> 1.89 s (-169.5 ms) vs ben/hitl-authorized-responders-design (fc0e46a).
  • Timing is informational: shared GitHub runners are too variable for a hard timing budget.
Detailed phase timings vs `ben/hitl-authorized-responders-design (fc0e46a)`
Phase Baseline Current Delta
extension.check 1.1 ms 1.1 ms 0.0 ms
project.resolve 0.6 ms 0.6 ms 0.0 ms
workspace.create 0.8 ms 0.7 ms -0.1 ms
host.prepare 387.0 ms 141.1 ms -245.9 ms
vercel.service-prefix.resolve 1.9 ms 2.0 ms +0.1 ms
nitro.create 229.5 ms 202.2 ms -27.3 ms
sandbox.prewarm 187.9 ms 206.5 ms +18.6 ms
nitro.cache.prepare 0.2 ms 0.2 ms 0.0 ms
nitro.prepare 0.7 ms 0.7 ms 0.0 ms
nitro.public-assets 0.8 ms 0.8 ms 0.0 ms
nitro.prerender 0.4 ms 0.5 ms +0.1 ms
nitro.bundle 1.24 s 1.30 s +63.2 ms
nitro.cache.write 0.3 ms 0.3 ms 0.0 ms
vercel.workflow-function.materialize 21.8 ms
agent-summary.emit 0.5 ms 0.5 ms 0.0 ms
nitro.close 0.1 ms 0.1 ms 0.0 ms
output.publish 3.4 ms 3.4 ms 0.0 ms
workspace.remove 1.9 ms 2.0 ms +0.1 ms

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

E2E HITL evals still send the old approval option IDs approve/deny, which no longer match the renamed allow/cancel options, so every affected approval eval fails.

Fix on Vercel

@benpankow
benpankow force-pushed the ben/hitl-approval-protocol branch from 0eea09b to a55bef2 Compare July 29, 2026 18:43
@benpankow benpankow changed the title feat(eve): rename approval responses to allow and cancel feat(eve): replace approval denial with cancel Jul 29, 2026
Signed-off-by: benpankow <ben.pankow@vercel.com>
@benpankow

Copy link
Copy Markdown
Collaborator Author

Superseded by the consolidated 7-PR implementation stack starting at #1368 (GitHub stack #1375).

@benpankow benpankow closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant