Skip to content

fix(eve): emit approval events after persistence - #1361

Closed
benpankow wants to merge 1 commit into
ben/hitl-slack-event-targetingfrom
ben/hitl-durable-event-ordering
Closed

fix(eve): emit approval events after persistence#1361
benpankow wants to merge 1 commit into
ben/hitl-slack-event-targetingfrom
ben/hitl-durable-event-ordering

Conversation

@benpankow

@benpankow benpankow commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Moves approval lifecycle emission onto durable workflow boundaries:

  • candidate creation returns a continuation before policy execution
  • approval.candidate pending is emitted from persisted candidate state
  • terminal settlement is emitted from persisted settlement audit state
  • tool execution/batch resolution proceeds only after settlement projection
  • emitted markers prevent replayed duplicate events
  • updates focused tests for the multi-step transition

This enforces the invariant that channel UI is always a projection of durable state rather than an optimistic in-step notification.

Validation

  • pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/harness/input-requests.test.ts src/harness/tool-loop.test.ts src/public/channels/slack/defaults.test.ts
  • pnpm --filter eve typecheck

Stack

Depends on #1360.

Signed-off-by: benpankow <ben.pankow@vercel.com>
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eve-docs Ready Ready Preview Jul 29, 2026 9:01pm
eve-docs-4759 Ready Ready Preview, v0 Jul 29, 2026 9:01pm

@github-actions

Copy link
Copy Markdown
Contributor

Bundle + Package Summary: apps/fixtures/weather-agent

Key takeaways

  • No notable deltas vs ben/hitl-slack-event-targeting (e5983b0).

Delta vs ben/hitl-slack-event-targeting (e5983b0)

Area Metric Baseline Current Delta
Package Packed tarball 7.43 MB 7.43 MB +180 B ⚠️
Package Unpacked publish size 27.97 MB 27.97 MB +2.0 kB ⚠️
Package Installed footprint 90.03 MB 90.03 MB +2.0 kB ⚠️
Package Published files 2792 2792 0
Package Installed files 6575 6575 0
Runtime Unique function payloads 2 2 0
Runtime Total function bytes 16.53 MB 16.54 MB +2.8 kB ⚠️
Runtime Public routes 11 11 0
Changed function payloads vs ben/hitl-slack-event-targeting (e5983b0) (2)
Function Status Baseline Current Delta Route changes
functions/__server.func changed 8.27 MB 8.27 MB +1.4 kB ⚠️ none
functions/.well-known/workflow/v1/flow.func changed 8.27 MB 8.27 MB +1.4 kB ⚠️ none

eve init install

Metric Baseline Current Delta
Installed footprint 128.43 MB 128.43 MB +2.0 kB ⚠️
Installed packages 130 130 0
dependencies 4 4 0
devDependencies 2 2 0
Dependency package bytes 42.35 MB 42.35 MB +2.0 kB ⚠️
devDependency package bytes 5.04 MB 5.04 MB 0 B ➖
Build Metadata
  • Preset: vercel
  • Nitro: nitro@3.0.260610-beta
  • Output directory: apps/fixtures/weather-agent/.vercel/output
  • Build metadata timestamp: 2026-07-29T21:02:23.112Z
  • Route aliases: 11 public, 1 internal (12 total aliases)
  • Vercel routes in config: 14
  • Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small
Package Drill-Down

Package Details

  • Package: eve@0.27.8
  • Package directory: packages/eve
  • Tarball: 7.43 MB (eve-0.27.8.tgz)
  • Unpacked payload: 27.97 MB across 2792 published files
  • Installed footprint: 90.03 MB across 6575 installed files
  • Installed root package: 26.69 MB
  • Installed dependencies: 63.34 MB
  • Runtime dependencies: 2
  • Peer dependencies: 5 (4 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.

Heavy installed dependencies

  • eve: 26.69 MB (29.6%)
  • @rolldown/binding-linux-x64-gnu: 19.28 MB (21.4%)
  • @rolldown/binding-wasm32-wasi: 10.66 MB (11.8%)
  • ai: 6.53 MB (7.3%)
  • @napi-rs/wasm-runtime: 6.39 MB (7.1%)
Publish payload breakdown
Published file size
🔴 dist/src/compiled/shadcn-registry/index.js       [########################] 13.15 MB 47.0%
🟠 dist/src/compiled/experimental-ai-sdk-code-mo... [###.....................] 1.51 MB 5.4%
🟡 dist/src/compiled/@vercel/sandbox/index.js       [#.......................] 632.4 kB 2.3%
🟡 dist/src/compiled/_chunks/workflow/undici-C2Z... [#.......................] 502.4 kB 1.8%
🟡 dist/src/compiled/@chat-adapter/slack/index.js   [#.......................] 440.5 kB 1.6%
🔴 Other published files                            [#####################...] 11.73 MB 42.0%
Installed footprint breakdown
Installed package size
🔴 eve                             [########################] 26.69 MB 29.6%
🔴 @rolldown/binding-linux-x64-gnu [#################.......] 19.28 MB 21.4%
🔴 @rolldown/binding-wasm32-wasi   [##########..............] 10.66 MB 11.8%
🔴 ai                              [######..................] 6.53 MB 7.3%
🔴 @napi-rs/wasm-runtime           [######..................] 6.39 MB 7.1%
🔴 zod                             [#####...................] 5.04 MB 5.6%
🔴 Other installed packages        [##############..........] 15.44 MB 17.2%
Runtime dependencies (2)
Package Range Notes
nitro 3.0.260610-beta
undici 7.28.0
Peer dependencies (5)
Package Range Notes
@opentelemetry/api ^1.0.0 optional peer
ai catalog:
braintrust ^3.0.0 optional peer
just-bash ^3.0.0 optional peer
microsandbox ^0.5.0 optional peer
eve init install drill-down

eve init install details

  • Command: eve init my-agent
  • Package manager: npm
  • Installed footprint: 128.43 MB across 8443 installed files
  • Installed packages: 130 total (124 transitive-only)
  • dependencies: 4 direct packages totaling 42.35 MB
  • devDependencies: 2 direct packages totaling 5.04 MB
  • Other transitive package files: 81.04 MB

Installed footprint is measured from an isolated temporary eve init my-agent using the current packed eve tarball.

Heavy installed dependencies

  • @typescript/typescript-linux-x64: 27.95 MB (21.8%)
  • eve: 26.69 MB (20.8%)
  • @rolldown/binding-linux-x64-gnu: 19.28 MB (15.0%)
  • @rolldown/binding-wasm32-wasi: 10.66 MB (8.3%)
  • zod: 9.00 MB (7.0%)
Installed footprint breakdown
Installed package size
🔴 @typescript/typescript-linux-x64 [########################] 27.95 MB 21.8%
🔴 eve                              [#######################.] 26.69 MB 20.8%
🔴 @rolldown/binding-linux-x64-gnu  [#################.......] 19.28 MB 15.0%
🔴 @rolldown/binding-wasm32-wasi    [#########...............] 10.66 MB 8.3%
🔴 zod                              [########................] 9.00 MB 7.0%
🔴 ai                               [######..................] 6.53 MB 5.1%
🔴 @napi-rs/wasm-runtime            [#####...................] 6.39 MB 5.0%
🔴 Other installed packages         [###################.....] 21.94 MB 17.1%
dependencies (4)
Package Range Installed size Share
@vercel/connect 0.4.2 135.8 kB 0.1%
ai ^7.0.34 6.53 MB 5.1%
eve file:eve-0.27.8.tgz 26.69 MB 20.8%
zod 4.4.3 9.00 MB 7.0%
devDependencies (2)
Package Range Installed size Share
@types/node 24.x 2.54 MB 2.0%
typescript 7.0.2 2.50 MB 1.9%
Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 8.27 MB 50.0%
🔴 functions/__server.func                         [########################] 8.27 MB 50.0%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 8.27 MB
Metric Value
Public routes /.well-known/workflow/v1/flow
Runtime nodejs24.x
Handler index.mjs
Payload 8.27 MB
Function files 8.27 MB across 44 files
Traced dependencies 0 B
Signal 🟠 Bundled file _chunks/runtime-artifacts.mjs is 1.58 MB (19.1%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 _chunks/runtime-artifacts.mjs [#############...........] 1.58 MB 19.1%
🟠 index.mjs                     [##########..............] 1.19 MB 14.4%
🟡 _libs/undici.mjs              [########................] 925.6 kB 11.2%
🟡 _chunks/world-vercel.mjs      [#######.................] 900.3 kB 10.9%
🟡 _chunks/sandbox.mjs           [######..................] 767.6 kB 9.3%
🟠 Other bundled files           [########################] 2.91 MB 35.2%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve776561746865722d6167656e74_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ],
  "environment": {
    "WORKFLOW_PRECONDITION_GUARD": "1"
  }
}

🟠 functions/__server.func • 10 public routes, 1 internal alias • 8.27 MB
Metric Value
Public routes /
/eve/v1/callback/[token]
/eve/v1/connections/[name]/callback/[token]
/eve/v1/health
/eve/v1/info
/eve/v1/session
/eve/v1/session/[sessionId]
/eve/v1/session/[sessionId]/cancel
/eve/v1/session/[sessionId]/stream
/eve/v1/session/reset
Internal aliases /__server
Runtime nodejs24.x
Handler index.mjs
Payload 8.27 MB
Function files 8.27 MB across 44 files
Traced dependencies 0 B
Signal 🟠 Bundled file _chunks/runtime-artifacts.mjs is 1.58 MB (19.1%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 _chunks/runtime-artifacts.mjs [#############...........] 1.58 MB 19.1%
🟠 index.mjs                     [##########..............] 1.19 MB 14.4%
🟡 _libs/undici.mjs              [########................] 925.6 kB 11.2%
🟡 _chunks/world-vercel.mjs      [#######.................] 900.3 kB 10.9%
🟡 _chunks/sandbox.mjs           [######..................] 767.6 kB 9.3%
🟠 Other bundled files           [########################] 2.91 MB 35.2%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

Build Timing: e2e/fixtures/agent-tools-sandbox

This is an informational timing measurement inside eve build, from preflight through publication. Output-size measurement and profile writing are excluded.

Build mode: deployable Vercel build with sandbox template prewarm included.

  • Build pipeline: 2.19 s -> 1.82 s (-375.6 ms) vs ben/hitl-slack-event-targeting (e5983b0).
  • Timing is informational: shared GitHub runners are too variable for a hard timing budget.
Detailed phase timings vs `ben/hitl-slack-event-targeting (e5983b0)`
Phase Baseline Current Delta
extension.check 1.1 ms 1.1 ms 0.0 ms
project.resolve 0.6 ms 0.5 ms -0.1 ms
workspace.create 0.7 ms 0.7 ms 0.0 ms
host.prepare 336.6 ms 144.7 ms -191.9 ms
vercel.service-prefix.resolve 1.8 ms 1.7 ms -0.1 ms
nitro.create 219.5 ms 204.9 ms -14.6 ms
sandbox.prewarm 356.3 ms 165.8 ms -190.5 ms
nitro.cache.prepare 0.3 ms 0.3 ms 0.0 ms
nitro.prepare 0.8 ms 0.8 ms 0.0 ms
nitro.public-assets 0.7 ms 0.7 ms 0.0 ms
nitro.prerender 0.4 ms 0.5 ms +0.1 ms
nitro.bundle 1.26 s 1.29 s +21.9 ms
nitro.cache.write 0.4 ms 0.4 ms 0.0 ms
agent-summary.emit 0.5 ms 0.4 ms -0.1 ms
nitro.close 0.1 ms 0.1 ms 0.0 ms
output.publish 3.5 ms 3.2 ms -0.3 ms
workspace.remove 2.0 ms 1.9 ms -0.1 ms

candidateId: pendingCandidateEvent.candidateId,
state: session.state,
}),
};

@vercel vercel Bot Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pending-approval-candidate event block emits the pending event and sets pendingEventEmitted but never returns { next: runStep }, so the step parks and the response-authorized approval flow deadlocks.

Fix on Vercel

@benpankow

Copy link
Copy Markdown
Collaborator Author

Superseded by the consolidated 7-PR implementation stack starting at #1368 (GitHub stack #1375).

@benpankow benpankow closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant