Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eve/src/channel/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export interface RouteHandlerArgs<TState = undefined> {

export interface SendPayload {
readonly message?: string | UserContent;
readonly [key: string]: unknown;
readonly inputResponses?: readonly InputResponse[];
/**
* Context strings contributed by the channel. eve appends each entry
Expand Down
37 changes: 31 additions & 6 deletions packages/eve/src/channel/send.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import type { ChannelAdapter } from "#channel/adapter.js";
import { createSendFn } from "#channel/send.js";
import type { RunHandle, Runtime } from "#channel/types.js";
import { RuntimeNoActiveSessionError } from "#execution/runtime-errors.js";
import type { MessageStreamEvent } from "#protocol/message.js";
import type { HandleMessageStreamEvent } from "#protocol/message.js";

function createMockRunHandle(): RunHandle {
return {
continuationToken: "test:token",
events: new ReadableStream<MessageStreamEvent>(),
events: new ReadableStream<HandleMessageStreamEvent>(),
sessionId: "mock-session-id",
};
}
Expand All @@ -20,7 +20,7 @@ function createRuntime(deliverError: unknown): Runtime {
deliver: vi.fn().mockRejectedValue(deliverError),
resolveSession: vi.fn(),
run: vi.fn().mockResolvedValue(createMockRunHandle()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<MessageStreamEvent>()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<HandleMessageStreamEvent>()),
getStreamTailIndex: vi.fn().mockResolvedValue(-1),
terminateSession: vi.fn(),
};
Expand Down Expand Up @@ -77,14 +77,39 @@ describe("createSendFn", () => {
expect(runtime.run).not.toHaveBeenCalled();
});

it("preserves channel-specific fields through delivery", async () => {
const runtime: Runtime = {
cancelTurn: vi.fn(),
deliver: vi.fn().mockResolvedValue({ sessionId: "existing-session-id" }),
resolveSession: vi.fn(),
run: vi.fn(),
getEventStream: vi.fn(),
getStreamTailIndex: vi.fn(),
terminateSession: vi.fn(),
};
const send = createSendFn(runtime, ADAPTER, "test");

await send(
{
inputResponses: [{ optionId: "approve", requestId: "approval-1" }],
pendingApprovalCards: { "approval-1": { messageTs: "123.456" } },
},
{ auth: null, continuationToken: "token" },
);

expect(vi.mocked(runtime.deliver).mock.calls[0]?.[0].payload).toMatchObject({
pendingApprovalCards: { "approval-1": { messageTs: "123.456" } },
});
});

it("forwards context through deliver and run payloads", async () => {
const context = ["thread background"];
const deliverRuntime: Runtime = {
cancelTurn: vi.fn(),
deliver: vi.fn().mockResolvedValue({ sessionId: "existing-session-id" }),
resolveSession: vi.fn(),
run: vi.fn().mockResolvedValue(createMockRunHandle()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<MessageStreamEvent>()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<HandleMessageStreamEvent>()),
getStreamTailIndex: vi.fn().mockResolvedValue(-1),
terminateSession: vi.fn(),
};
Expand Down Expand Up @@ -119,7 +144,7 @@ describe("createSendFn", () => {
deliver: vi.fn().mockResolvedValue({ sessionId: "existing-session-id" }),
resolveSession: vi.fn(),
run: vi.fn().mockResolvedValue(createMockRunHandle()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<MessageStreamEvent>()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<HandleMessageStreamEvent>()),
getStreamTailIndex: vi.fn().mockResolvedValue(-1),
terminateSession: vi.fn(),
};
Expand Down Expand Up @@ -149,7 +174,7 @@ describe("createSendFn", () => {
deliver: vi.fn().mockResolvedValue({ sessionId: "existing-session-id" }),
resolveSession: vi.fn(),
run: vi.fn().mockResolvedValue(createMockRunHandle()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<MessageStreamEvent>()),
getEventStream: vi.fn().mockResolvedValue(new ReadableStream<HandleMessageStreamEvent>()),
getStreamTailIndex: vi.fn().mockResolvedValue(-1),
terminateSession: vi.fn(),
};
Expand Down
3 changes: 2 additions & 1 deletion packages/eve/src/channel/send.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export function createSendFn<TState = undefined>(
inputResponses,
context,
outputSchema,
...channelPayload
} = normalizeSendInput(input);
const message = serializeUrlFilePartsInMessage(rawMessage);

Expand All @@ -39,7 +40,7 @@ export function createSendFn<TState = undefined>(
auth,
continuationToken,
requestId: metadata.requestId,
payload: { inputResponses, message, context, outputSchema },
payload: { ...channelPayload, inputResponses, message, context, outputSchema },
};
const { sessionId } = await runtime.deliver(deliverInput);

Expand Down
Loading
Loading