refactor(next): remove unused thread state module - #1393
Draft
vercel-gh-bot-3[bot] wants to merge 1 commit into
Draft
refactor(next): remove unused thread state module#1393vercel-gh-bot-3[bot] wants to merge 1 commit into
vercel-gh-bot-3[bot] wants to merge 1 commit into
Conversation
Co-authored-by: ruiconti <1834568+ruiconti@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete 286 lines of unused code from the Next.js framework example.
Why
A calibrated Knip scan reported
app/_chat/thread-state.tsafter package exports, framework entry points, generated files, tests, and runtime plugins were configured as controls. Repository and history searches found no importer or runtime registration. The file has remained disconnected since its initial commit.Next.js does not treat this underscore-prefixed module as a route. A production build confirmed that no route or bundle depends on it.
Approach
Because the app reaches chat state through explicit imports, deleting the disconnected module should leave behavior unchanged. This also removes
ChatSessionCursorandThreadState, which had no remaining references.Verification
pnpm --filter framework-next typecheckpnpm --filter framework-next build:nextpnpm lintpnpm guard:invariantspnpm --filter framework-next lintcannot start becauseeslint-plugin-react@7.37.5calls an API removed ineslint@10.4.0. The failure occurs on unchangedagent/agent.tsbefore this diff is linted.Requested by: rui.lealsalvadorconti