refactor(eve): resolve every sandbox path through one resolver - #1466
Draft
chadhietala wants to merge 1 commit into
Draft
refactor(eve): resolve every sandbox path through one resolver#1466chadhietala wants to merge 1 commit into
chadhietala wants to merge 1 commit into
Conversation
#1459 added `resolveSandboxModelPath` to expand a leading `$HOME` for the sandbox file tools, but left two older paths doing the same work their own way. `resolveSandboxSkillRoot` kept its own probe-and-join, which needed `HOME_SKILL_SUFFIX` — a second spelling of the `.agents/skills` tail that `MODEL_SKILL_ROOT` already carries, with nothing to keep the two in step. Resolving `MODEL_SKILL_ROOT` through the new resolver produces the same root in both the usable-home and fallback cases, so the join helper and the duplicate suffix are gone and the skills location is written once. `resolveSandboxSeedFilePath` had become a wrapper that narrowed the resolver to skill paths only. Seed files come from exactly two roots — `WORKSPACE_ROOT` and `MODEL_SKILL_ROOT` — so the narrowing could not change any real input, and the single call site now calls the resolver directly. `MODEL_SKILL_ROOT` is derived from `MODEL_HOME_ROOT` so `$HOME` also appears once. Signed-off-by: Chad Hietala <chadhietala@gmail.com>
chadhietala
added
the
simplify-devbox
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found
resolveSandboxSkillRootkept its own probe-and-join built onHOME_SKILL_SUFFIX— a second spelling of the.agents/skillstailMODEL_SKILL_ROOTalready carries, with nothing keeping them in step.resolveSandboxSeedFilePathhad become a wrapper narrowing fix(eve): skills - resolve $HOME paths in file tools #1459's new resolver to skill paths, which its only caller cannot trigger (seed files come fromWORKSPACE_ROOTorMODEL_SKILL_ROOT).Did
Both now go through
resolveSandboxModelPath, andMODEL_SKILL_ROOTis derived fromMODEL_HOME_ROOT, so$HOMEand the skills tail are each written once. −24/+11; neither helper was exported from the package.Validated
84 unit tests pass across skill-paths and the read/write/glob/grep tools —
$HOMEexpansion, bare$HOME,$HOME_DIRlookalikes, unusable-home fallback, probe caching. One edit points the seed assertion at the surviving resolver.tsc --noEmit, lint, fmt,guard:invariantsclean.