Skip to content

fix(security): Predictable global cache directory in /tmp enables symlink/hijack risks #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(security): Predictable global cache directory in /tmp enables symlink/hijack risks #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/utils/ncc-cache-dir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
module.exports = require("os").tmpdir() + "/ncc-cache";
const crypto = require("crypto");
const os = require("os");
const path = require("path");

const cacheBase = process.env.XDG_CACHE_HOME || path.join(os.homedir(), ".cache");
const projectKey = crypto.createHash("sha256").update(process.cwd()).digest("hex").slice(0, 12);
Copy link
Copy Markdown
Member

@styfle styfle Apr 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const projectKey = crypto.createHash("sha256").update(process.cwd()).digest("hex").slice(0, 12);
const projectKey = crypto.createHash("sha1").update(process.cwd()).digest("hex");

No reason to truncate. Just use a smaller hashing function if you don't need the entropy.


module.exports = path.join(cacheBase, "ncc", projectKey);
Loading