Repository navigation
feat: move Seedance and Omni video onto the job contract - #351
Merged
Merged
Conversation
Seedance
- Runs on fal's queue API (submit, status, result, cancel) instead of the
blocking `subscribe`, so a paid job keeps its request ID from the moment
it is accepted and can be polled or cancelled after a crash.
- A COMPLETED status can still be a failure: `error` is checked first, and
a rejection raised when the result is read (the likeness 422) is a failed
job with kind `likeness`, not a thrown read.
- A data-URI first or last frame is uploaded to fal storage instead of
being silently dropped (which turned image-to-video into text-to-video).
- Tests run the real fal SDK against the fake network.
Omni
- Submits with `background: true` and polls the interaction, then the
Files API until the video is ACTIVE. Omni accepts background mode although
the docs list only text models; the completed interaction carries the
video URI (probed live).
- Edit and extend chain with `previous_interaction_id`, so an Omni job
handle is its session handle. Cancel uses POST /interactions/{id}/cancel.
- A completed interaction with no video reads as moderation.
Both keep a blocking `generateVideo` that submits and waits, so CLI
callers are unchanged until the CLI moves to the contract.
Claude-Session: https://claude.ai/code/session_011S1BLTaFctZNQzGERpkCuA
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third PR of the provider interface work (after #349 and #350). With this, every video provider except Veo (shutting down 2026-10-22) is on the contract.
Seedance
subscribe. A paid job keeps its request ID from the moment it is accepted, so it can be polled or cancelled after a crash. Before, a crash mid-wait lost it.erroris checked first. A rejection raised when the result is read, like the likeness 422, is reported as a failed job of kindlikeness(codecontent_policy_violation).@fal-ai/clientSDK against the fake network instead of mockingsubscribe. Every earlier assertion is kept.Omni
background: trueand pollsGET /interactions/{id}, then the Files API until the video is ACTIVE.google.md.previous_interaction_id. Cancel uses the documentedPOST /interactions/{id}/cancel.moderation. Omni's filter can finish that way.Compatibility
Both keep a blocking
generateVideothat submits and waits, so CLI callers are unchanged until the CLI moves to the contract (next PR).Verification
PROCESSINGbeforeACTIVE.pnpm build,lint,typecheck, tests (providers 205, CLI 1215, MCP 73), pre-push gate.vibe generate video -p seedance --seedance-model fast --resolution 480p --duration 4: 4.1 s, 864x496.vibe generate video -p omni --resolution 360p: 10.0 s, 640x360.https://claude.ai/code/session_011S1BLTaFctZNQzGERpkCuA