Skip to content

Refactor crypto wallet implementation - #1388

Merged
aurelticot merged 56 commits into
developfrom
feature/1294-epic-refactor-crypto-wallet-implementation
Apr 11, 2024
Merged

Refactor crypto wallet implementation#1388
aurelticot merged 56 commits into
developfrom
feature/1294-epic-refactor-crypto-wallet-implementation

Conversation

@aurelticot

@aurelticot aurelticot commented Apr 2, 2024

Copy link
Copy Markdown
Member

💭 What's changed?

Essentially:

  • Refactoring on the types
  • Migration of persisted crypto wallet records in the Vault, to use the blockchain namespace as wallet type rather than the blockchain chainId

🧪 How to test these changes?

  • Create, Import crypto wallet
  • Add watched wallet

😨 Anything to be aware of?

For next PR

@aurelticot aurelticot added this to the 1.3.0 milestone Apr 2, 2024
@aurelticot aurelticot self-assigned this Apr 2, 2024
@aurelticot aurelticot linked an issue Apr 2, 2024 that may be closed by this pull request
…' into feature/1091-refactor-the-crypto-wallet-model-2
…' into feature/1091-refactor-the-crypto-wallet-model-2
…' into feature/1091-refactor-the-crypto-wallet-model-2
@aurelticot
aurelticot marked this pull request as ready for review April 11, 2024 21:45
@aurelticot

Copy link
Copy Markdown
Member Author

Merging this one as it gather already approved small PRs

@aurelticot
aurelticot merged commit 981b352 into develop Apr 11, 2024
@aurelticot
aurelticot deleted the feature/1294-epic-refactor-crypto-wallet-implementation branch April 11, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EPIC] Refactor crypto wallet implementation

1 participant