co: Is Ordered Subset Of - #449
Open
YetiGonk wants to merge 2 commits into
Open
Conversation
davidverisian
approved these changes
Mar 19, 2026
davidverisian
left a comment
davidverisian
left a comment
There was a problem hiding this comment.
Just 1 comment to address, then looks good.
| if isinstance(self.validation_df, DaskDataset): | ||
| results = self.validation_df.apply(check_order, axis=1, meta=("check_order", bool)) | ||
| results = self.validation_df.convert_to_series(results) | ||
| else: |
There was a problem hiding this comment.
Should there also be a last case with a ValueError in case none of these match? That's how I remember it was done in some places like contains_all_operator.py
Author
There was a problem hiding this comment.
Oh yeah! good catch, I'll add now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check operator that checks if the given target array (column, list, or collection operation result) is an ordered subset of the comparator array.
Feel free to bash on my sql queries, they are definitely overkill.