[data, torch_profile] test: add st of torch and mstx by 756017542 · Pull Request #23 · verl-project/rl-insight

756017542 · 2026-03-18T07:09:57Z

What does this PR do?

add st of torch and mstx

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

Search for similar PRs. Paste at least one query link here: ...
Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
- {modules} include mstx, mvtx, torch_profile, deployment, perf, algo, env, doc, data, cfg, ci, misc,
- If this PR involves multiple modules, separate them with , like [mstx, ci]
- {type} is in feat, fix, refactor, chore, test
- If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
- Example: [BREAKING][mstx, torch_profile] feat: support timeline parsing

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Read the Contribute Guide.
Apply pre-commit checks: pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always
Add / Update the documentation.
Add unit or end-to-end test(s) to the CI workflow to cover all the code. If not feasible, explain why: ...

gemini-code-assist · 2026-03-18T07:10:23Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the testing infrastructure by introducing end-to-end tests for MSTX and PyTorch profilers. It provides concrete examples of profiler outputs and a utility for data compression, ensuring the robustness and maintainability of the profiling analysis tools.

Highlights

New End-to-End Tests: Added dedicated end-to-end tests for both MSTX and PyTorch profilers to validate their output generation and functionality.
Sample Profiling Data: Included new sample profiling data files for both MSTX and PyTorch, which are used by the newly added E2E tests.
JSON to JSON.GZ Conversion Utility: Introduced a Python script to convert standard JSON files into a gzipped JSON format, potentially for storage or transfer efficiency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for torch and mstx profilers, including new test data and end-to-end tests. My review focuses on improving the quality and robustness of the new tests and utility scripts. I've suggested using pytest fixtures to make the tests cleaner and more reliable. For the new data conversion script, I've recommended changes to make it more reusable and to improve its error handling. I also pointed out some inconsistencies in the test data and a best practice of not committing generated files to the repository.

tardis-key · 2026-03-19T10:40:07Z

ci name is not correct.

Moocharr · 2026-03-20T07:06:12Z

+
+      - name: Install dependencies
+        run: |
+          pip install -r requirements.txt


pip install 没有使用 --no-cache-dir，建议添加 --no-cache-dir 避免缓存问题

Moocharr · 2026-03-20T07:06:54Z

+
+      - name: Run profiling_data_analysis_st tests
+        run: |
+          pytest -s -x tests/special_e2e


pytest 没有超时限制，建议添加 --timeout=300 或其他合适的超时设置

Moocharr · 2026-03-20T07:07:34Z

+
+      - name: Run profiling_data_analysis_st tests
+        run: |
+          pytest -s -x tests/special_e2e


文件末尾缺少空行，添加空行以符合POSIX标准

tardis-key · 2026-03-24T08:44:44Z

+```
+### 数据解析文件 prof_*.json.gz，解析文件缺少字段见解析日志warning，解析文件内容示例：
+
+![img_1.png](img_1.png)


use text instead of png

Moocharr · 2026-03-24T11:40:32Z

+└── <role>/
+    └── prof_*.json.gz
+```
+### 数据解析文件 prof_*.json.gz，解析文件内容包含distrubutedInfo、traceEvent等字段，数据内容一般包含ts、dur等字段，解析文件内容示例：


标题太长，建议拆解成标题和正文

Moocharr · 2026-03-24T11:40:41Z

+        └── ASCEND_PROFILER_OUTPUT/
+            └── trace_view.json
+```
+### 数据解析文件 trace_view.json，解析文件内容必须包含"ph": "M"，且"name": "Overlap Analysis"对应"pid"的数据，该数据一般包含ts、dur等字段，解析文件内容示例：


Moocharr · 2026-03-24T11:43:57Z

@@ -0,0 +1,101 @@
+[


修改文件路径，文件夹名字非公共部分可以用xxx表述

Moocharr · 2026-03-24T11:44:13Z

@@ -0,0 +1,50 @@
+{


Rhetee · 2026-03-26T07:07:31Z

/lgtm

gemini-code-assist Bot reviewed Mar 18, 2026

View reviewed changes

add st of torch

6b9ec5e

756017542 force-pushed the main branch from 371b1bc to 6b9ec5e Compare March 18, 2026 08:07

756017542 changed the title ~~add st of torch and mstx~~ add st of torch Mar 18, 2026

Rhetee reviewed Mar 18, 2026

View reviewed changes

Comment thread torch_data/jsontojsongz.py Outdated

756017542 changed the title ~~add st of torch~~ [data, torch_profile] test: add st of torch Mar 19, 2026

756017542 force-pushed the main branch from 653fff8 to 6b9ec5e Compare March 19, 2026 02:07

delate json

611ac8a

tardis-key requested changes Mar 19, 2026

View reviewed changes

Comment thread tests/special_e2e/test_torch_e2e.py

Comment thread tests/special_e2e/test_torch_e2e.py Outdated

Comment thread tests/special_e2e/test_torch_e2e.py Outdated

Comment thread tests/special_e2e/test_torch_e2e.py Outdated

gcw_fbonFwWl added 6 commits March 19, 2026 11:22

add special_e2e

1ec779e

code check

fcc73d1

code check

396af62

add special_e2e.yml

2cd7aea

mv data and fix bug

57023db

bugfix

c4d6066

tardis-key reviewed Mar 19, 2026

View reviewed changes

Comment thread docs/data/data_directory.md

gcw_fbonFwWl added 2 commits March 19, 2026 18:56

add st of mstx

46cea5e

Revise inspection comments

69c7e49

756017542 changed the title ~~[data, torch_profile] test: add st of torch~~ [data, torch_profile] test: add st of torch and mstx Mar 19, 2026

gcw_fbonFwWl added 2 commits March 20, 2026 09:34

change st name

577e936

Add data description

20d174c

Moocharr reviewed Mar 23, 2026

View reviewed changes

gcw_fbonFwWl added 2 commits March 23, 2026 17:39

add data file

e1ca74c

delate st --timeout=300

45b81c0

tardis-key reviewed Mar 24, 2026

View reviewed changes

delate img.png

24bbc48

Moocharr reviewed Mar 24, 2026

View reviewed changes

revise data_directory

afe614e

Moocharr approved these changes Mar 25, 2026

View reviewed changes

tardis-key merged commit 19f838b into verl-project:main Mar 25, 2026
4 checks passed

tardis-key mentioned this pull request Mar 25, 2026

[roadmap] RL-Insight Q1 Roadmap #6

Closed

19 tasks

Conversation

756017542 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist Before Starting

Test

API and Usage Example

Design & Code Changes

Checklist Before Submitting

Uh oh!

gemini-code-assist Bot commented Mar 18, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tardis-key commented Mar 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rhetee commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

756017542 commented Mar 18, 2026 •

edited

Loading