[parser] feat: add memory parser#54
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new MemoryClusterParser to extract memory allocation data from Ascend Profiler outputs, including a design document, ijson-based streaming parsing, and comprehensive tests. The reviewer identified several critical issues: a naming mismatch in the MemoryEventRow schema that would cause KeyErrors in the base parser, potential ValueErrors when parsing empty CSV fields, missing validation rules for new data types, and brittle directory sorting logic. Addressing these points will ensure the parser is robust and compatible with the existing framework.
tardis-key
reviewed
May 11, 2026
tardis-key
reviewed
May 11, 2026
tardis-key
reviewed
May 11, 2026
tardis-key
reviewed
May 11, 2026
tardis-key
reviewed
May 11, 2026
tardis-key
reviewed
May 11, 2026
HUZZZW
reviewed
May 20, 2026
tardis-key
reviewed
May 21, 2026
7ed92d1 to
735044b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add memory parser
issue -> #42
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includepipeline,parser,visualizer,data,deployment,perf,algo,env,doc,cfg,ci,misc,like[mstx, ci]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][mstx, torch_profile] feat: support timeline parsingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always