Skip to content

[parser] feat: add memory parser#54

Merged
tardis-key merged 3 commits into
verl-project:mainfrom
Moocharr:main_tmp
May 26, 2026
Merged

[parser] feat: add memory parser#54
tardis-key merged 3 commits into
verl-project:mainfrom
Moocharr:main_tmp

Conversation

@Moocharr
Copy link
Copy Markdown
Contributor

What does this PR do?

add memory parser
issue -> #42

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include pipeline, parser, visualizer, data, deployment, perf, algo, env, doc, cfg, ci, misc
    • If this PR involves multiple modules, separate them with , like [mstx, ci]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][mstx, torch_profile] feat: support timeline parsing

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new MemoryClusterParser to extract memory allocation data from Ascend Profiler outputs, including a design document, ijson-based streaming parsing, and comprehensive tests. The reviewer identified several critical issues: a naming mismatch in the MemoryEventRow schema that would cause KeyErrors in the base parser, potential ValueErrors when parsing empty CSV fields, missing validation rules for new data types, and brittle directory sorting logic. Addressing these points will ensure the parser is robust and compatible with the existing framework.

Comment thread rl_insight/utils/schema.py Outdated
Comment thread rl_insight/parser/memory_parser.py Outdated
Comment thread rl_insight/parser/memory_parser.py Outdated
Comment thread rl_insight/data/data_checker.py
Comment thread rl_insight/parser/memory_parser.py Outdated
Comment thread tests/parser/test_memory_parser.py Outdated
Comment thread docs/memory_parser_design.md Outdated
Comment thread docs/memory_parser_design.md Outdated
Comment thread rl_insight/data/data_checker.py
Comment thread rl_insight/data/data_checker.py
Comment thread rl_insight/parser/memory_parser.py
Comment thread rl_insight/parser/memory_parser.py Outdated
Comment thread rl_insight/parser/memory_parser.py
Comment thread rl_insight/parser/memory_parser.py
Comment thread rl_insight/parser/memory_parser.py
Comment thread rl_insight/parser/memory_parser.py Outdated
Comment thread rl_insight/parser/__init__.py
@Moocharr Moocharr changed the title [memory] feat: add memory parser [parser] feat: add memory parser May 21, 2026
@Moocharr Moocharr force-pushed the main_tmp branch 2 times, most recently from 7ed92d1 to 735044b Compare May 25, 2026 06:51
@tardis-key tardis-key mentioned this pull request May 26, 2026
24 tasks
@tardis-key tardis-key merged commit 326e817 into verl-project:main May 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants