[cfg] refactor: Use omegaconf structured configuration system#58
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the project's configuration and CLI argument handling from argparse to a structured system based on OmegaConf. It introduces dataclass-based schemas, YAML presets, and a new key=value CLI format, with corresponding updates across documentation, example scripts, and the test suite. Review feedback identifies a potential AttributeError when rendering help for complex type hints and notes that mandatory field validation is currently unreachable due to OmegaConf's internal error handling. Additionally, there are suggestions to use more idiomatic OmegaConf methods for configuration retrieval and to decouple visualizer selection logic to improve long-term maintainability.
tardis-key
reviewed
May 21, 2026
tardis-key
approved these changes
May 22, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--argformat tokey=valueformatChecklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includepipeline,parser,visualizer,data,deployment,perf,algo,env,doc,cfg,ci,misc,like[mstx, ci]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][mstx, torch_profile] feat: support timeline parsingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always