[veomni, cfg] feat: add missing config fields to veomni.yaml#6505
[veomni, cfg] feat: add missing config fields to veomni.yaml#6505mikequan0425 wants to merge 6 commits into
Conversation
…components in veomni ops_implementation
|
|
There was a problem hiding this comment.
Code Review
This pull request introduces several new configuration options to the VeOmni engine, specifically adding support for Qwen3.5-related kernel implementations (such as gated RMSNorm, causal conv1d, and chunk gated delta-rule). It also adds several new configuration parameters to veomni.yaml. The review feedback correctly identifies that several of these newly added configuration parameters (including grad_offload, offload_policy, wrap_policy, dtype, and use_orig_params) are currently ignored or unsupported by the underlying VeOmniEngine implementation, and recommends either removing them or implementing proper support.
…ining engine as suggested by Gemini
FoolPlayer
left a comment
There was a problem hiding this comment.
Thanks for your PR, the only problem is some args only for FSDP1, but VeOmni has already remove FSDP1 support after v0.1.10. And VeOmni 0.1.11 will be used with verl 0.8.0
…guration based on reviews, as the latest version of veomni no longer supports fsdp1.
|
@FoolPlayer Thank you for your review and your excellent work on Veomni. I have revised everything based on your suggestions. |
|
@FoolPlayer @wuxibin89 pre-commit failed in CI, I've pushed the updates again. Could you help trigger CI again? Thanks! |
What does this PR do?
Supplement the configurations available in engine.py but missing in engine/veomni.yaml, and add new optional operators in the veomni OpsImplementationConfig.
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
After completing the configuration in the script, the logs show that it has taken effect successfully.
API and Usage Example
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.