Skip to content

[megatron] fix: zero out mtp_num_layers and trim csa_compress_ratios on vanilla_mbridge=True path #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Meirtz wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

[megatron] fix: zero out mtp_num_layers and trim csa_compress_ratios on vanilla_mbridge=True path #6515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions verl/workers/engine/megatron/transformer_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,14 @@ def _build_tf_config(self):
from verl.models.mcore.mbridge import AutoBridge

bridge = AutoBridge.from_config(self.model_config.hf_config, dtype=self.param_dtype)
if not self.model_config.mtp.enable:
override_transformer_config["mtp_num_layers"] = 0
bridge.set_extra_args(**override_transformer_config)
if not self.model_config.mtp.enable:
csa = getattr(bridge.config, "csa_compress_ratios", None)
num_layers = getattr(bridge.config, "num_layers", None)
if csa is not None and num_layers is not None and len(csa) > num_layers:
bridge.config.csa_compress_ratios = list(csa[:num_layers])
tf_config = bridge.config
tf_config.fp16 = self.param_dtype == torch.float16
tf_config.bf16 = self.param_dtype == torch.bfloat16
Expand Down
Loading