[fsdp, model] feat: support glm_moe_dsa FSDP training with DSA attention#6525
Open
Kite0011 wants to merge 9 commits into
Open
[fsdp, model] feat: support glm_moe_dsa FSDP training with DSA attention#6525Kite0011 wants to merge 9 commits into
Kite0011 wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the glm_moe_dsa model type, including a custom attention forward implementation (glm_moe_dsa_attn_forward_with_dsa) that supports Ulysses sequence parallelism and padding removal, corresponding monkey patching, and FLOPs estimation. The review feedback highlights several potential runtime issues: position_ids needs to be unsqueezed to 2D if it is 1D to avoid shape mismatches; 2D or 3D attention_mask inputs should be unsqueezed to 4D before combining with index_mask to prevent crashes; the FLOPs counter must safely handle configurations where q_lora_rank is None; and use_fused_kernels should be explicitly disabled for glm_moe_dsa since they are not supported.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add FSDP training support for the glm_moe_dsa model, including:
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
loss converge using a random glm_moe_dsa model 10 step

task: open_reasoning_math sft
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.