fix: add missing 'column' dependency and update installer for modern debian/ubuntu#3
Open
sliva-dev wants to merge 2 commits intovernette:masterfrom
Open
fix: add missing 'column' dependency and update installer for modern debian/ubuntu#3sliva-dev wants to merge 2 commits intovernette:masterfrom
sliva-dev wants to merge 2 commits intovernette:masterfrom
Conversation
…debian/ubuntu Problem The script fails on minimal OS installations (e.g., bare Debian/Ubuntu or slim Docker images) with the following error: `column: command not found` This happens because the script relies on `column -t` for result formatting, but doesn't check for this dependency or include it in the automatic installer. Changes - Added `column` to the `DEPENDENCIES` list and `DEPENDENCY_COMMANDS` mapping. - Updated `install_with_package_manager` to support modern package names: - Debian/Ubuntu: Added logic to install `bsdextrautils`. - Arch Linux/Fedora/CentOS: Added `util-linux` to provide the `column` utility. - Ensured the script handles dependency installation before attempting to print the final results table. Testing performed - Verified on a minimal Ubuntu Server 24.04 installation where `column` was missing. - Confirmed that the script correctly prompts for and installs the required package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The script fails on minimal OS installations (e.g., bare Debian/Ubuntu or slim Docker images) with the following error:
column: command not foundThis happens because the script relies on
column -tfor result formatting, but doesn't check for this dependency or include it in the automatic installer.Changes
columnto theDEPENDENCIESlist andDEPENDENCY_COMMANDSmapping.install_with_package_managerto support modern package names:bsdextrautils.util-linuxto provide thecolumnutility.Testing performed
columnwas missing.