Skip to content

fix: Sanitize terminal hyperlinks in plain output - #164

Merged
jack-arturo merged 1 commit into
feat/installer-visual-flairfrom
codex/fix-installer-flair-control-regex
Jun 26, 2026
Merged

fix: Sanitize terminal hyperlinks in plain output#164
jack-arturo merged 1 commit into
feat/installer-visual-flairfrom
codex/fix-installer-flair-control-regex

Conversation

@jack-arturo

Copy link
Copy Markdown
Member

Summary

  • Replaces the no-control-regex-triggering hyperlink label sanitizer with shared char-code control-character encoding.
  • Keeps theme.link plain for no-color/non-TTY output so CI and redirected stdout do not receive OSC 8 control sequences.
  • Adds regression coverage for plain/color hyperlink behavior plus invalid and non-http URL fallback text.

Verification

  • npm run lint exits 0 with 156 existing warnings and no errors.
  • npm test -- src/cli/ui/ui.test.ts --reporter=dot passes 1 file / 25 tests.
  • git diff --check

Review

  • Independent review found missing regression coverage; fixed.
  • Independent review found plain-mode OSC 8 leakage; fixed.
  • Independent review found invalid/non-http URL fallback still returned raw control text; fixed.
  • Final re-review returned no findings.

Stacked on top of feat/installer-visual-flair because that feature branch already has PR #157 open.

@jack-arturo jack-arturo changed the title [codex] Sanitize terminal hyperlinks in plain output fix: Sanitize terminal hyperlinks in plain output Jun 26, 2026
@jack-arturo
jack-arturo merged commit 5885c1e into feat/installer-visual-flair Jun 26, 2026
1 of 2 checks passed
@jack-arturo
jack-arturo deleted the codex/fix-installer-flair-control-regex branch June 26, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant