ci: exclude racy release-asset links from lychee link check - #166
Open
jack-arturo wants to merge 1 commit into
Open
ci: exclude racy release-asset links from lychee link check#166jack-arturo wants to merge 1 commit into
jack-arturo wants to merge 1 commit into
Conversation
The README "Download (.mcpb)" button points at releases/latest/download/mcp-automem.mcpb. On a release merge the CI link check runs concurrently with the release workflow, which creates the GitHub release ~1 minute before the build-extension job uploads the .mcpb asset. Lychee checked the URL inside that window and got a 404, failing CI on an otherwise-successful release (v0.15.0). Exclude release-asset "latest download" URLs from the check, mirroring the existing exclusion for racy compare links. The asset is still validated by the build-extension job that produces it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
/copilot-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Excludes release-asset "latest download" URLs from the
Check Links(lychee) job.
Why
The v0.15.0 release succeeded end to end — npm published with provenance,
tag + GitHub release created,
.mcpbasset uploaded — but the CI run onthe release-merge commit went red. The
Check Linksjob hit:This is a race, not a broken doc. The README "Download (.mcpb)" button
(README.md:117)
points at
releases/latest/download/…. On a release merge, CI runsconcurrently with the release workflow, which creates the GitHub release
~1 minute before the
build-extensionjob uploads the.mcpbasset.Lychee checked the URL inside that window → 404 → CI failure on a perfectly
good release.
Fix
Add
--exclude 'github.com/.*/releases/latest/download/.*', mirroring theexisting exclusion for racy
compare/...links. The asset is stillvalidated where it's produced — the
build-extensionjob fails loudly ifthe
.mcpbcan't be built.Notes
.mcpbsupport is unaffected — it's still built and shipped each release.this only prevents recurrence on future releases.