Prevent stale profile role from undoing linked tag role changes. - #2
Merged
Merged
Conversation
When tags are edited on the user profile screen, WordPress was still saving the posted role and reverting the role set by linked tags.
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents a user’s role from being unintentionally reverted when editing tags on the WordPress user profile screen, by ensuring the stale posted role value doesn’t overwrite role changes triggered by linked tags.
Changes:
- After adding/removing a role in
tags_modified(), clears the postedrolevalue during profile updates to avoid WordPress re-saving it. - Introduces a small private helper (
prevent_profile_role_overwrite()) to encapsulate the profile-update detection and$_POST['role']unsetting logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tags are edited on the user profile screen, WordPress was still saving the posted role and reverting the role set by linked tags.