Skip to content

[Core] 3 - Protect Board and settings saves #463

Description

@KacperKozak

What to build

Extend shared persistence contracts through Board and settings save/read/delete callers on Android and iOS. Replace ordinary handwritten iOS writes with GRDB records; keep Room entity writes and preserve Board tombstones and settings semantics.

Part 3 of the approved cross-platform persistence reliability plan. Android and iOS remain separate native implementations with shared observable contracts. Local planning document: docs/persistence-reliability-plan.md; this issue is self-contained. Type: AFK.

Likely files

  • modules/vescape-core/ios/telemetry/AppDataRepository.swift - production behavior or caller to inspect
  • modules/vescape-core/ios/telemetry/AppDataRepositorySettingsTests.swift - existing verification seam
  • modules/vescape-core/ios/telemetry/AppDataRepositoryBoardLinkTests.swift - existing verification seam
  • modules/vescape-core/android/src/main/java/expo/modules/vescapecore/telemetry/AppDataRepository.kt - production behavior or caller to inspect
  • modules/vescape-core/src/index.ts - native bridge contract

Implementation hints

Keep Room on Android and GRDB on iOS. Native owns durable truth; JS renders state and sends intents. Follow bidirectional @parity links and preserve bridge payloads. Custom SQL is allowed for migrations and aggregate updates with real DB tests. Use existing error UI and avoid a generic persistence/recovery framework. Diagnostics transport follows ADR 0031; Sentry handles errors independently of local event persistence. Use bun commands and appropriate scoped verification.

Acceptance criteria

  • Both runners verify Board identity, rename, tombstone, settings update/default handling and reopen preservation.
  • Failed save rejects caller and never reports success; failed reads are explicit errors rather than default settings. Reuse slice 2 failure/reporting behavior.
  • No new UI recovery framework; preserve existing successful flows and native ownership.
  • Validate transactional failures and existing migration/restore data shapes.

Blocked by

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:coreApp shell, storage, lifecycle, infraarea:dbTouches database / persistent storagearea:nativeTouches native side (modules/vesc-ble, Swift/Kotlin)complexity:highCritical paths, subtle correctness, native pipelines. Use opus.enhancementNew feature or requestready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions