[Core] 4 - Protect Favorite storage operations

[KacperKozak]

What to build

Cover Favorite create, rename, trim, delete, reopen, and Favorite Media manifest behavior through both native implementations and their callers. Use GRDB records for ordinary iOS writes; preserve pinning and media ownership.

Part 4 of the approved cross-platform persistence reliability plan. Android and iOS remain separate native implementations with shared observable contracts. Local planning document: docs/persistence-reliability-plan.md; this issue is self-contained. Type: AFK.

Likely files

• modules/vescape-core/ios/telemetry/FavoriteStore.swift - production behavior or caller to inspect
• modules/vescape-core/ios/telemetry/FavoriteMediaStore.swift - production behavior or caller to inspect
• modules/vescape-core/ios/telemetry/FavoriteStoreTests.swift - existing verification seam
• modules/vescape-core/android/src/main/java/expo/modules/vescapecore/telemetry/TelemetryDao.kt - production behavior or caller to inspect
• src/modules/history/store/historyStore.ts - production behavior or caller to inspect

Implementation hints

Keep Room on Android and GRDB on iOS. Native owns durable truth; JS renders state and sends intents. Follow bidirectional @parity links and preserve bridge payloads. Custom SQL is allowed for migrations and aggregate updates with real DB tests. Use existing error UI and avoid a generic persistence/recovery framework. Diagnostics transport follows ADR 0031; Sentry handles errors independently of local event persistence. Use bun commands and appropriate scoped verification.

Acceptance criteria

• Shared fixtures assert matching saved ranges, summaries and deletion/pinning behavior across platforms.
• Failure rolls back DB changes and is surfaced to callers and Sentry via established mechanism; do not invent atomicity across SQLite and media files.
• Cover failed media-manifest operations using existing cleanup semantics, with no silent successful save.
• Existing Favorite UI receives simple errors; maintain parity tags and restore format.

Blocked by

• [Core] 1 - Test recording across hosts #461
• [Core] 2 - Surface recording storage failures #462

Related

• [Core] 1 - Test recording across hosts #461
• [Core] 2 - Surface recording storage failures #462
• [Core] 3 - Protect Board and settings saves #463
• [Core] 5 - Protect Tune and alert storage #465
• [Core] 6 - Surface history read failures #466
• [Core] 7 - Cover remaining persistence contracts #467
• [Core] 8 - Verify migrations and backup restore #468
• [Core] 9 - Gate releases on storage contracts #469

[KacperKozak]

Implemented in cf93347. Favorite create/update/delete and media manifest failures now propagate through native reporting, destructive media reconciliation aborts on database read failure, and shared Android/macOS host contracts verify exact summaries, ranges, ownership, pinning, reopen/delete behavior, filesystem preservation, and transaction rollback. Verified with bun run test:persistence:android, bun run test:persistence:ios, bun run test:ios, Android module compile/FavoriteMediaTest, and bun run ts.