Skip to content

[Core] 9 - Gate releases on storage contracts #469

Description

@KacperKozak

What to build

Wire both host persistence contract suites into required CI/release prerequisites for the exact released revision. Keep device smoke tests separate for OS lifecycle and background recording.

Part 9 of the approved cross-platform persistence reliability plan. Android and iOS remain separate native implementations with shared observable contracts. Local planning document: docs/persistence-reliability-plan.md; this issue is self-contained. Type: AFK.

Likely files

  • .github/workflows/ci.yml - CI/release integration
  • .github/workflows/release-ios.yml - CI/release integration
  • .github/workflows/release-android.yml - CI/release integration
  • .github/workflows/promote-production.yml - CI/release integration
  • scripts/test-ios.ts - host test/build entry point
  • docs/persistence-reliability-plan.md - production behavior or caller to inspect

Implementation hints

Keep Room on Android and GRDB on iOS. Native owns durable truth; JS renders state and sends intents. Follow bidirectional @parity links and preserve bridge payloads. Custom SQL is allowed for migrations and aggregate updates with real DB tests. Use existing error UI and avoid a generic persistence/recovery framework. Diagnostics transport follows ADR 0031; Sentry handles errors independently of local event persistence. Use bun commands and appropriate scoped verification.

Acceptance criteria

  • Both Android and iOS release paths cannot publish a revision with failing or missing native storage contracts; verify branch protection/workflow dependencies rather than assuming CI presence suffices.
  • Use host runners, caching and changed-file selection only where safe; coverage cannot skip a platform or migration scenario silently.
  • Demonstrate failed fixture blocks release gate and passing suites permit continuation without actually publishing a release.
  • Document commands, measured runtimes, ownership of shared fixtures and supported upgrade matrix.

Blocked by

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:coreApp shell, storage, lifecycle, infraarea:dbTouches database / persistent storagearea:nativeTouches native side (modules/vesc-ble, Swift/Kotlin)complexity:mediumNeeds care, moderate integration surface. Use sonnet.enhancementNew feature or requestready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions