fix: surface malformed-bundle errors + unknown-field warnings (discovery loader output)#25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle discovery was discarding the manifest loader's output, so two distinct problems shared one root cause:
bundle '<name>' not found(exit 3) — indistinguishable from a typo'd name. The real, actionable error was thrown away.skils:) was silently ignored.This threads the loader's full result through
BundleEntryand surfaces it across every command:UsageError); a genuinely-absent name still →not found, exit 3 (NotFoundError). The two stay distinguishable.:colon-space in an unquoteddescription) now becomes an actionableUsageErrorwith adescription: >-block-scalar hint (reusing the73fdda7pattern), not a rawYAMLException.extendschain and surfaced: stderr onbuild/run/apply(exit 0 preserved), and merged intoshow's## warningssection (de-duplicated).umbel listflags a malformed row asNAME ⚠with the reason in the DESCRIPTION column; clean bundles are unchanged.Closes #6 (folds in #7, which was closed as a duplicate).
How it was built
TDD, 8 tasks, fresh subagent per task with two-stage (spec + code-quality) review, plus a final whole-branch review. Commits are scoped one-per-seam (manifest → discover → compose → exec → list → show → run → integration + a small
emitWarningsDRY refactor).Test Plan
npm test— 368/368 pass (39 files), incl. newtest/integration/cli.bundle-malformed.test.tsnpx tsc --noEmit— cleanbiome check .— cleanbuild <malformed>→ exit 2 + real reason;build <ghost>→ exit 3 + "not found";build <unknown-field>→ exit 0 + stderr warning;listshows⚠row;showlists manifest warnings.Follow-ups captured (out of scope)
umbel-8k9— whether an unknown frontmatter field should fail-fast (hard error) vs the current documented soft-warning (forward-compat trade-off; needs an ADR + spec decision).umbel-3gb— a malformed parent reached viaextendsstill reports "missing parent" (exit 3) rather than the parent's real error (same class as this issue, one level removed).