fix(signal): kill phantom findings and un-hide real ones across patterns, breaking, perf, semgrep and coverage - #21

Merged

m-szymanska merged 137 commits into

mainfrom

fix/verdict-signal-truth

Aug 23, 2026

Commits on Aug 22, 2026

fix(signal): require word boundaries for pattern-scan keywords
vetcoders-agents
committed
24c613b
fix(signal): pair non-fn remove+re-add to kill phantom removed symbols

vetcoders-agents
and
claude
committed
25b3343
fix(checks): classify semgrep tool errors as skipped, not code failures
vetcoders-agents
committed
f8bb536
fix(heuristics): classify perf test-context per hit, not per hunk
vetcoders-agents
committed
7205a69
merge: fix/pattern-word-boundaries
vetcoders-agents
committed
ccc4b3b
merge: fix/breaking-phantom-nonfn
vetcoders-agents
committed
6e15d58
merge: fix/perf-test-context-per-hit
vetcoders-agents
committed
c8a9322
merge: fix/semgrep-exit2-tool-error
vetcoders-agents
committed
50fc500
fix(signal): represent unmeasured coverage as not-measured, not 100%

vetcoders-agents
and
claude
committed
62fa2b4
fix(report): mark skipped heuristics explicitly instead of zero-filled results

vetcoders-agents
and
claude
committed
f17cb2d
merge: skip-as-zero residual (fix/skip-as-zero-residual)
vetcoders-agents
committed
f1f0af7
chore(deps): bump ammonia 4.1.3 -> 4.1.4 (RUSTSEC-2026-0213 XSS fix)

vetcoders-agents
and
claude
committed
399788d
fix(verdict): stop reporting warnings as failed quality checks

vetcoders-agents
and
claude
committed
fc1548c
fix(gate): fail loud when the pack carries no readable verdict

vetcoders-agents
and
claude
committed
122759e
merge: warnings are not failures (fix/warning-not-failure)
vetcoders-agents
committed
6dc3e89
merge: readers stop guessing (fix/read-hardening)
vetcoders-agents
committed
5b4b5aa
fix(perf): read test context from the patch target state only

vetcoders-agents
and
claude
committed
f5f65f6
fix(signal): scope and full-declaration pairing for breaking changes

vetcoders-agents
and
claude
committed
0d34430
docs(changelog): record perf context and breaking pairing fixes

vetcoders-agents
and
claude
committed
319efc7
test(output): adapt cut-1 exit-code tests to fail-loud gate reader

vetcoders-agents
and
claude
committed
3a77da2
merge: review followup for signal trackers (perf + breaking)

vetcoders-agents
and
claude
committed
b4b30c3
fix(perf): ignore trailing comments when resolving test context

vetcoders-agents
and
claude
committed
afa2e58
docs(breaking): record the measured basis for hunk-local module scope

vetcoders-agents
and
claude
committed
7e31486
fix(gate): make MERGE_GATE.json state its schema and its failure origins

vetcoders-agents
and
claude
committed
968c23f
fix(report): stamp report.json as schema 2.0 for its nullable coverage ratio

vetcoders-agents
and
claude
committed
f5df942
docs(changelog): record the round-2 review followups

vetcoders-agents
and
claude
committed
43237a3
merge: round-2 review followup (schema truth, comment-aware trackers)

vetcoders-agents
and
claude
committed
14ee56d
fix(breaking): pair duplicate public declarations one-to-one

vetcoders-agents
and
claude
committed
6819939
fix(perf): ignore braces inside string and char literals

vetcoders-agents
and
claude
committed
92ed337
fix(gate): hold the schema contract to the validator's exact strings

vetcoders-agents
and
claude
committed
ee1ccac
docs(changelog): record the round-3 review followups

vetcoders-agents
and
claude
committed
c1572f9
merge: round-3 review followup (one-to-one pairing, literal-aware tracker, canonical schema strings)

vetcoders-agents
and
claude
committed
889dfd3
fix(perf): simplify token-start guard to satisfy clippy 1.94

vetcoders-agents
and
claude
committed
f3ae43d
fix(output): treat a versioned pack without a decision object as corrupt

vetcoders-agents
and
claude
committed
72917c9
merge: versioned packs must carry a decision object

vetcoders-agents
and
claude
committed
99328d1
fix(gate): force conservative axes when a verdict is normalized to BLOCK

vetcoders-agents
and
claude
committed
9d06224
fix(signal): ignore literal and comment braces when tracking module scope

vetcoders-agents
and
claude
committed
937d998
fix(checks): preserve stdout diagnostics in the semgrep skip reason

vetcoders-agents
and
claude
committed
04f1119
docs: record the round-6 signal fixes in the changelog and gate contract

vetcoders-agents
and
claude
committed
50b21b1
merge: round-6 review followup (normalized BLOCK axes, literal/comment braces, semgrep stdout)

vetcoders-agents
and
claude
committed
560fa7e
fix(regression): track block comments across lines when reading test scope

vetcoders-agents
and
claude
committed
a353b42
fix(signal): keep cfg guards and literal delimiters out of declaration pairing

vetcoders-agents
and
claude
committed
12c61b7
fix(signal): read pattern-scan word boundaries per character, not per ASCII byte

vetcoders-agents
and
claude
committed
dee5356
fix(report): tell a disabled heuristics run apart from an unavailable scanner

vetcoders-agents
and
claude
committed
b9a0f6a
merge: round-7 review followup (single-pass rust lexer, cfg-aware pairing, unicode word boundaries, disabled-vs-unavailable heuristics)

vetcoders-agents
and
claude
committed
ed562d2
fix(gate): reject mistyped decision signals in the CLI reader

vetcoders-agents
and
claude
committed
02f1ba4
fix(mcp): read legacy root-shaped gate packs instead of calling them corrupt

vetcoders-agents
and
claude
committed
6b75fd3
test(rust-source): pin raw strings that contain a comment marker

vetcoders-agents
and
claude
committed
2603657
merge: round-8 review followup (typed gate readers on both surfaces, legacy root decisions in MCP, raw-string lexer guard)

vetcoders-agents
and
claude
committed
b2380dc
fix(scanner): carry an open string literal across lines

vetcoders-agents
and
claude
committed
1fb70a4
fix(breaking): treat a stack of cfg attributes as one conjunction

vetcoders-agents
and
claude
committed
2ab1255
fix(gate): reject a non-object legacy decision root on both readers

vetcoders-agents
and
claude
committed
fb63938
fix(gate): reconcile contradictory decision axes by conservativeness

vetcoders-agents
and
claude
committed
c8a1d54
fix(cli): count the pack's canonical checks for --fail-on-warnings

vetcoders-agents
and
claude
committed
f25caf3
merge: round-9 review followup (multiline literal state, cfg conjunction, conservative reconciliation, pack-canonical warnings tally)

vetcoders-agents
and
claude
committed
d94ebdc
fix(scanner): recognize raw C string literals

vetcoders-agents
and
claude
committed
09a6c2f
docs(gate): pin the decision-object precedence for schema-less packs

vetcoders-agents
and
claude
committed
968fcc6
docs(breaking): record why a module name is not carried to a later brace

vetcoders-agents
and
claude
committed
3d45c3c
docs(patterns): record the combining-mark limit of word-boundary matching

vetcoders-agents
and
claude
committed
54de7b4
merge: round-10 review followup (raw C strings, decision precedence pinned, measured deferrals)

vetcoders-agents
and
claude
committed
f8f77bb
fix(gate): fold every verdict spelling through one shared vocabulary

vetcoders-agents
and
claude
committed
fa16d4b
fix(breaking): read a cfg attribute to its balanced close

vetcoders-agents
and
claude
committed
cee2a2d
fix(breaking): stop cutting declaration text inside real signatures

vetcoders-agents
and
claude
committed
c6dc609
fix(perf): close a test context opened over an item with no body

vetcoders-agents
and
claude
committed
b7d5bb3
merge: round-11 review followup (shared verdict vocabulary, balanced cfg attribute reads, declaration cap widened, bodiless test-context close)

vetcoders-agents
and
claude
committed
62267c5
fix(patterns): bound every needle on the side that has an identifier edge

vetcoders-agents
and
claude
committed
8775485
merge: round-12 review followup (needle-edge word bounding, eprint family pinned)

vetcoders-agents
and
claude
committed
4dc55cf
merge: sync PR #21 with main after #19 (docs + ammonia) and #20 (substrate)

vetcoders-agents
and
claude
committed
a6848e8
fix(breaking): end a line comment at the line that wrote it

vetcoders-agents
and
claude
committed
dd6f40d
merge: re-sync with main after changelog marker hotfix (7caa392)
vetcoders-agents
committed
8a5f17f
fix(breaking): count a cfg_attr that applies a cfg as a guard

vetcoders-agents
and
claude
committed
f17f650
fix(report): carry the quality-failure origin into report.json

vetcoders-agents
and
claude
committed
0bc31c7
docs(breaking): record the item-body blind spot as an accepted 0.8 limit

vetcoders-agents
and
claude
committed
9338fb5
merge: round-13 review followup (cfg_attr guards, origin in report.json, comment-resolved declaration completeness, accepted-limit record)

vetcoders-agents
and
claude
committed
94baf42
fix(perf): find the test body's opener past the signature's brackets

vetcoders-agents
and
claude
committed
e4342aa
fix(breaking): compare declarations without their comments

vetcoders-agents
and
claude
committed
be2fb0d
merge: round-14 review followup (comment-free comparison identity, signature-bracket body opener)

vetcoders-agents
and
claude
committed
c392ed1
docs(changelog): the scanner does carry a literal across lines

vetcoders-agents
and
claude
committed
04d39bc
fix(breaking): count square brackets before a semicolon ends a declaration

vetcoders-agents
and
claude
committed
a243e14
fix(breaking): separate identity lines by the boundary that separated them

vetcoders-agents
and
claude
committed
6159852
fix(breaking): keep the raw-identifier prefix in a module scope name

vetcoders-agents
and
claude
committed
13ecf23
docs(breaking): record the cfg block-comment counter as a measured limit

vetcoders-agents
and
claude
committed
0ac7762
fix(perf): read a `<` as a generic opener only where one can be

vetcoders-agents
and
claude
committed
79ad601
merge: round-15 review followup (array-type semicolons, literal newlines in identity, raw-ident scopes, comparison-aware sig brackets, measured cfg-comment deferral)

vetcoders-agents
and
claude
committed
860ff34

Commits on Aug 23, 2026

fix(signal): keep a cfg guard across a block comment

vetcoders-agents
and
claude
committed
61a60ee
fix(signal): read a const argument as type, not as a body opener

vetcoders-agents
and
claude
committed
cd65d73
fix(cli): refuse a merge gate decision that states no signal

vetcoders-agents
and
claude
committed
9c515ad
merge: round-16 review followup (comment-aware cfg runs, const-argument braces, decision-signal presence contract)

vetcoders-agents
and
claude
committed
ebc9f98
fix(cli): honor --ci strictness on update runs and reused packs

vetcoders-agents
and
claude
committed
106e4ac
fix(mcp): align the decision reader with the CLI on unrankable signals

vetcoders-agents
and
claude
committed
2e16d9d
fix(signal): track the whole generic argument list when finding a body brace

vetcoders-agents
and
claude
committed
0dc537b
merge: round-17 review followup (generic-argument const blocks, MCP/CLI reader parity, unchanged-update exit honesty)

vetcoders-agents
and
claude
committed
2d842da
fix(signal): read an initializer brace as a value, not an item body

vetcoders-agents
and
claude
committed
fad95ec
fix(signal): keep a line break in a declaration identity only inside a literal

vetcoders-agents
and
claude
committed
850388d
fix(perf): open inline test context only on a gate that provably holds in tests

vetcoders-agents
and
claude
committed
793cd47
fix(artifacts): escape pipes in the breaking-changes markdown tables

vetcoders-agents
and
claude
committed
b1ca07c
merge: round-18 final followup (initializer blocks, reflow-stable identity, provable test-context, table escaping)

vetcoders-agents
and
claude
committed
d1da1e7
refactor(gate): keep the decision-signal reader helpers internal

vetcoders-agents
and
claude
committed
c5b8621
fix(gate): rank a failed quality axis in the conservative reconciliation

vetcoders-agents
and
claude
committed
58aecb2
fix(artifacts): fence a table code span longer than the backticks inside it

vetcoders-agents
and
claude
committed
27609e6
merge: micro-round-19 followup (crate-private gate readers, quality axis in reconciliation, backtick-safe table cells)

vetcoders-agents
and
claude
committed
5b9cdf3
fix(breaking): reconstruct both sides of a hunk instead of truncating at shared lines

vetcoders-agents
and
claude
committed
dbf8621
fix(gate): type quality_pass through readable_signal on both readers

vetcoders-agents
and
claude
committed
25e3b32
fix(perf): accept a cfg(all(...)) test operand at any position

vetcoders-agents
and
claude
committed
3b4662c
fix(validator): require name and a known classification on 2.2 quality entries

vetcoders-agents
and
claude
committed
a746e73
merge: round-20 followup (typed quality axis, context-fed pending declarations, all() operand order, validator fail-closed details)

vetcoders-agents
and
claude
committed
06cfcf1
fix(gate): rank the analysis and blocker axes, and close the axis table

vetcoders-agents
and
claude
committed
856c8c7
fix(perf): match cfg markers against whole attributes, not physical lines

vetcoders-agents
and
claude
committed
a943fe4
merge: round-21 followup (complete decision-axis reconciliation, multiline cfg attributes in perf tracker)

vetcoders-agents
and
claude
committed
c3cba73
fix(output): publish an absent decision axis from the reconciled outcome

vetcoders-agents
and
claude
committed
8cdc464
fix(perf): skip attribute brackets when looking for the item body

vetcoders-agents
and
claude
committed
67af56a
merge: round-22 followup (attribute-blind brace scan, legacy quality inference)

vetcoders-agents
and
claude
committed
3261304
fix(breaking): freeze generic depth inside a const argument

vetcoders-agents
and
claude
committed
0ae6822
docs(breaking): record cfg operand order as an accepted pairing limit

vetcoders-agents
and
claude
committed
411f1b6
merge: round-23 followup (angle freeze inside const blocks, measured cfg-reorder limit)

vetcoders-agents
and
claude
committed
e621b25
fix(perf): freeze signature tracking inside a const argument's braces

vetcoders-agents
and
claude
committed
c3659b4
fix(validator): reject a quality_pass that contradicts its own details

vetcoders-agents
and
claude
committed
2952c2d
merge: round-24 followup (signature-block freeze in perf tracker, quality invariant in validator)

vetcoders-agents
and
claude
committed
dece207
fix(breaking): accept a turbofish as a generic argument list opener

vetcoders-agents
and
claude
committed
9989eeb
merge: round-25 followup (turbofish opener in declaration tracking)

vetcoders-agents
and
claude
committed
b85f2ac
fix(perf): stop tracking generics after a body-less item's initializer

vetcoders-agents
and
claude
committed
996d999
fix(validator): require a boolean quality_pass from schema 2.2

vetcoders-agents
and
claude
committed
067fd8a
fix(breaking): keep literal edge whitespace out of the trimming

vetcoders-agents
and
claude
committed
8bbd361
merge: round-26 followup (initializer freeze in perf, required boolean quality axis, literal-edge whitespace identity)

vetcoders-agents
and
claude
committed
943e194
fix(breaking): count attribute delimiters on a literal-free view

vetcoders-agents
and
claude
committed
7587597
fix(gate): pin checks[].status to the emitted vocabulary

vetcoders-agents
and
claude
committed
635855b
merge: round-27 followup (literal-aware attribute delimiters, closed check-status vocabulary)

vetcoders-agents
and
claude
committed
2d9674d
fix(breaking): normalize cfg spacing without reaching into a value

vetcoders-agents
and
claude
committed
0fc1c92
fix(output): count an unreadable checks list as a warning

vetcoders-agents
and
claude
committed
7cf3544
merge: round-28 followup (literal-verbatim cfg guard normalization, unreadable checks container)

vetcoders-agents
and
claude
committed
350fdf1
fix(breaking): carry literal bytes through the attribute pipeline verbatim

vetcoders-agents
and
claude
committed
267baa8
fix(validator): certify the decision reconciliation, not just the shape

vetcoders-agents
and
claude
committed
4102d9f
merge: round-29 followup (verbatim-literal attribute pipeline invariant, full decision-axis validator port)

vetcoders-agents
and
claude
committed
433eea5
fix(breaking): count the impl owner as part of a declaration site

vetcoders-agents
and
claude
committed
ed2ac22
merge: round-30 followup (impl owner in pairing scope when visible)

vetcoders-agents
and
claude
committed
4e6506f
fix(contract): certify policy_allow_merge against its blocking_issues
vetcoders-agents
committed
6976898
merge: round-31 followup (policy_allow_merge equivalence with blocking_issues)

vetcoders-agents
and
claude
committed
d72d11c