fix(ci): allow security check reporting - #26
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the CI “Security Audit” job failing to publish results by granting only that job the minimum additional GITHUB_TOKEN permissions needed to create a GitHub Check Run, while keeping the rest of the workflow unchanged.
Changes:
- Add job-scoped
permissionsto thesecurityjob in.github/workflows/ci.yml. - Grant
contents: read(for checkout) andchecks: write(to publish the audit check run) specifically for the Security Audit job.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustsec/audit-checkpermission to create its Check RunRoot cause
The post-merge
mainrun completedcargo auditwith zero vulnerabilities, then failed while creating a Check Run because the repository defaultsGITHUB_TOKENto read-only.Validation
actionlint .github/workflows/ci.ymlcargo fmt --checkcargo +1.94 clippy --all-targets --all-features -- -D warningscargo test(hermetic Semgrep test double)